Skip to content

Commit e0f4329

Browse files
committed
Add PR review checklist
1 parent baab9a6 commit e0f4329

File tree

1 file changed

+65
-0
lines changed

1 file changed

+65
-0
lines changed
Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
# Standard PR Review Checklist
2+
3+
## PR Meta Information
4+
5+
- **PR Title**: Ensure the PR title is clear, concise, and adheres to the project's naming standards (e.g., `[Feature] Add X`, `[Bugfix] Fix Y`, `[Refactor] Z`).
6+
- **Description**: Include a detailed description explaining:
7+
- What the PR does.
8+
- Why the changes are necessary.
9+
- Links to related issues, tickets, or tasks (if applicable).
10+
- **Checklist in Description (Optional)**: Include a checklist of tasks completed (if the project uses task checklists).
11+
- **Reviewer Assignment**: The PR must be assigned to at least one reviewer.
12+
- **Labels/Tags (Optional)**: Ensure the PR has appropriate labels/tags (e.g., `Bugfix`, `Feature`, `Documentation`).
13+
14+
## Code Changes
15+
16+
- **Scope of Changes**:
17+
- PR should contain changes related to only one feature, bugfix, or task.
18+
- Avoid mixing multiple unrelated changes in one PR.
19+
- **Clean Code**:
20+
- Code should follow the project's coding standards (naming conventions, indentation, spacing).
21+
- Ensure proper formatting (auto-format code if tools are available).
22+
- **No Repetition**: Avoid duplicate code; refactor into reusable functions or components where possible.
23+
- **No Hardcoded Values**: Replace hardcoded values with constants, environment variables, or configurations.
24+
25+
## Quality and Best Practices
26+
27+
- **Tests**:
28+
- Ensure unit tests or integration tests are added/updated for the feature or bugfix.
29+
- Run all tests and confirm they pass locally.
30+
- **Linting and Static Analysis**:
31+
- Code should pass all linting checks (e.g., ESLint, Flake8, etc.).
32+
- Resolve any warnings or errors flagged by static analysis tools.
33+
- **Error Handling**: Ensure proper error handling is implemented (avoid swallowing errors silently).
34+
- **Performance Considerations**: Check for code efficiency (e.g., avoid unnecessary loops, database queries, or API calls).
35+
36+
## Compliance
37+
38+
- **CI/CD Pipelines**:
39+
- Ensure all CI pipelines (builds, tests, deployments) pass successfully.
40+
- Attach a CI screenshot if the pipelines aren't integrated into the PR system.
41+
- **Security**:
42+
- Verify no sensitive information (API keys, passwords, etc.) is exposed in the code or configuration.
43+
- Check for usage of secure methods and libraries.
44+
- **Backward Compatibility**: Ensure the changes don't break existing functionality or introduce regressions.
45+
46+
## Documentation and UI
47+
48+
- **Documentation (Optional)**: Update relevant documentation (e.g., README, API documentation, comments) for new features or changes.
49+
- **Screenshots/Videos (Optional)**:
50+
- Add screenshots or video recordings for UI changes (if applicable).
51+
- Ensure the UI matches the design and is responsive on different screen sizes.
52+
53+
## Miscellaneous
54+
55+
- **Dead Code**: Remove any unused code, variables, or imports.
56+
- **Debugging Artifacts**: Ensure no debugging code (e.g., `console.log`, `print`) is left in the codebase.
57+
- **Dependencies (Optional)**:
58+
- Verify no unnecessary or outdated dependencies are introduced.
59+
- Lock file changes (e.g., `package-lock.json`, `requirements.txt`) should be reviewed.
60+
61+
## Final Checks
62+
63+
- **Self-Review**: The developer submitting the PR must perform a thorough self-review before assigning it to a reviewer.
64+
- **Cross-Environment Testing (Optional)**: Confirm the changes work in multiple environments (e.g., dev, staging, production).
65+
- **Feature Flags (Optional)**: Ensure new features are behind feature flags if they are not fully ready for release.

0 commit comments

Comments
 (0)