Skip to content

Commit e458b9e

Browse files
authored
ROU-11456: Small improvements in pipelines (#441)
This PR is for adding small improvements on the github actions. ### What was happening - The way the github actions were accessing to the secrets and passing as input parameter to other actions; - The version of the external github action `actions/checkout` ### What was done - Now, github actions that require secrets access to them directly - `actions/checkout` was standardized to v4 - Tested changes in the sandbox ### Checklist - [x] tested locally - [ ] documented the code - [ ] clean all warnings and errors of eslint - [ ] requires changes in OutSystems (if so, provide a module with changes) - [ ] requires new sample page in OutSystems (if so, provide a module with changes)
2 parents ef36d9c + 3615e4c commit e458b9e

File tree

4 files changed

+4
-26
lines changed

4 files changed

+4
-26
lines changed
Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
11
name: 'setup-gpg'
22
description: 'Prepare to get following commits signed'
3-
inputs:
4-
gpgPriv:
5-
description: 'GPG Private key'
6-
required: true
7-
default: ''
8-
gpgPassPhrase:
9-
description: 'GPG passphrase'
10-
required: false
11-
default: '""'
123

134
runs:
145
using: composite
156
steps:
167
- name: Import and load GPG key
178
uses: crazy-max/ghaction-import-gpg@v6
189
with:
19-
gpg_private_key: ${{ inputs.gpgPriv }}
20-
passphrase: ${{ inputs.gpgPassPhrase }}
10+
gpg_private_key: ${{ secrets.GPG_SIGN_KEY }}
11+
passphrase: ${{ secrets.GPG_PASSPHRASE }}
2112
git_user_signingkey: true
2213
git_commit_gpgsign: true

.github/os-git-actions/signed-commit/action.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,12 @@ inputs:
1313
description: 'Defines if a `git add.` should be made or not.'
1414
required: false
1515
default: false
16-
gpgPriv:
17-
description: 'GPG Private key'
18-
required: true
19-
default: ''
20-
gpgPassPhrase:
21-
description: 'GPG passphrase'
22-
required: false
23-
default: '""'
2416

2517
runs:
2618
using: composite
2719
steps:
2820
- name: Setup GPG to sign commits
2921
uses: ./.github/os-git-actions/setup-gpg/
30-
with:
31-
gpgPriv: ${{ inputs.gpgPriv }}
32-
gpgPassPhrase: ${{ inputs.gpgPassPhrase }}
3322

3423
- name: Perform git commit
3524
uses: ./.github/os-git-actions/manual-commit/

.github/workflows/DevPR.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
working-directory: ./
1313
steps:
1414
- name: Checkout branch dev
15-
uses: actions/checkout@v2
15+
uses: actions/checkout@v4
1616

1717
- name: Install project dependencies
1818
run: npm install
@@ -25,7 +25,7 @@ jobs:
2525
runs-on: ubuntu-latest
2626
steps:
2727
- name: Checkout branch dev
28-
uses: actions/checkout@v2
28+
uses: actions/checkout@v4
2929

3030
- name: Install project dependencies
3131
run: npm install

.github/workflows/PreRelease.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,5 +119,3 @@ jobs:
119119
branch: dev
120120
message: 'Updated into v${{ inputs.new-dev-release }} [skip ci]'
121121
newFiles: true
122-
gpgPriv: ${{ secrets.GPG_SIGN_KEY }}
123-
gpgPassPhrase: ${{ secrets.GPG_PASSPHRASE }}

0 commit comments

Comments
 (0)