fixes Baseflow#58: made work in a separate thread (Baseflow#103)

* fixes Baseflow#58: made work in a separate thread

* chore: updated changelog.md to reflect changes

* chore: updated version on pubspec.yaml

* chore: updated version on pubspec.yaml

* chore: removed unused line

* feat: added addressLine

* Revert "feat: added addressLine"

This reverts commit 80590f2.

* chore: code formatting and review changes

* chore: revert  java.home path

* chore: used taskQueue

* chore: fixed reviews

Author: Mayb3Nots

geocoding/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.0.5
+
+- Fixed [#58](https://github.com/Baseflow/flutter-geocoding/issues/58) getting locationFromAddress freezes main thread.
+
 ## 2.0.4
 
 - Fixes link to the Android migration guide in README.

geocoding/android/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-14/"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-18/"/>
 	<classpathentry kind="con" path="org.eclipse.buildship.core.gradleclasspathcontainer"/>
 	<classpathentry kind="output" path="bin/default"/>
 </classpath>

geocoding/android/.settings/org.eclipse.buildship.core.prefs

@@ -1,7 +1,7 @@
 arguments=
 auto.sync=false
 build.scans.enabled=false
-connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(6.3))
+connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(7.1.1))
 connection.project.dir=
 eclipse.preferences.version=1
 gradle.user.home=

geocoding/android/build.gradle

@@ -8,7 +8,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.5.0'
+        classpath 'com.android.tools.build:gradle:4.2.2'
     }
 }
 
@@ -31,3 +31,7 @@ android {
         disable 'InvalidPackage'
     }
 }
+
+dependencies {
+    implementation 'androidx.annotation:annotation:1.4.0'
+}

geocoding/android/src/main/java/com/baseflow/geocoding/MethodCallHandlerImpl.java

@@ -2,19 +2,21 @@
 
 import android.location.Address;
 import android.util.Log;
+
 import androidx.annotation.Nullable;
 
 import com.baseflow.geocoding.utils.AddressMapper;
 import com.baseflow.geocoding.utils.LocaleConverter;
 
+import java.io.IOException;
+import java.util.List;
+
 import io.flutter.plugin.common.BinaryMessenger;
 import io.flutter.plugin.common.MethodCall;
 import io.flutter.plugin.common.MethodChannel;
 import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
 import io.flutter.plugin.common.MethodChannel.Result;
-
-import java.io.IOException;
-import java.util.List;
+import io.flutter.plugin.common.StandardMethodCodec;
 
 /**
  * Translates incoming Geocoding MethodCalls into well formed Java function calls for {@link
@@ -23,15 +25,18 @@
 final class MethodCallHandlerImpl implements MethodCallHandler {
     private static final String TAG = "MethodCallHandlerImpl";
     private final Geocoding geocoding;
-    @Nullable private MethodChannel channel;
+    @Nullable
+    private MethodChannel channel;
 
-    /** Forwards all incoming MethodChannel calls to the given {@code geocoding}. */
+    /**
+     * Forwards all incoming MethodChannel calls to the given {@code geocoding}.
+     */
     MethodCallHandlerImpl(Geocoding geocoding) {
         this.geocoding = geocoding;
     }
 
     @Override
-    public void onMethodCall(MethodCall call, Result result) {
+    public void onMethodCall(final MethodCall call, final Result result) {
         switch (call.method) {
             case "locationFromAddress":
                 onLocationFromAddress(call, result);
@@ -57,8 +62,8 @@ void startListening(BinaryMessenger messenger) {
             Log.wtf(TAG, "Setting a method call handler before the last was disposed.");
             stopListening();
         }
-
-        channel = new MethodChannel(messenger, "flutter.baseflow.com/geocoding");
+        final BinaryMessenger.TaskQueue taskQueue = messenger.makeBackgroundTaskQueue();
+        channel = new MethodChannel(messenger, "flutter.baseflow.com/geocoding", StandardMethodCodec.INSTANCE, taskQueue);
         channel.setMethodCallHandler(this);
     }
 
@@ -111,7 +116,7 @@ private void onLocationFromAddress(MethodCall call, Result result) {
         }
     }
 
-    private void onPlacemarkFromCoordinates(MethodCall call, Result result) {
+    private void onPlacemarkFromCoordinates(final MethodCall call, final Result result) {
         final double latitude = call.argument("latitude");
         final double longitude = call.argument("longitude");
         final String languageTag = call.argument("localeIdentifier");
@@ -121,15 +126,13 @@ private void onPlacemarkFromCoordinates(MethodCall call, Result result) {
                     latitude,
                     longitude,
                     LocaleConverter.fromLanguageTag(languageTag));
-
             if (addresses == null || addresses.isEmpty()) {
                 result.error(
                         "NOT_FOUND",
                         String.format("No address information found for supplied coordinates (latitude: %f, longitude: %f).", latitude, longitude),
                         null);
                 return;
             }
-
             result.success(AddressMapper.toAddressHashMapList(addresses));
         } catch (IOException ex) {
             result.error(

geocoding/pubspec.yaml

@@ -1,6 +1,6 @@
 name: geocoding
 description: A Flutter Geocoding plugin which provides easy geocoding and reverse-geocoding features.
-version: 2.0.4
+version: 2.0.5
 homepage: https://github.com/baseflow/flutter-geocoding/tree/master/geocoding
 
 environment: