Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical Error in Latest Version #460

Open
Temmie19 opened this issue Dec 6, 2017 · 2 comments
Open

Graphical Error in Latest Version #460

Temmie19 opened this issue Dec 6, 2017 · 2 comments

Comments

@Temmie19
Copy link

Temmie19 commented Dec 6, 2017

Thank you for reporting an issue with LanteaCraft. Please fill out this template when submitting your report - thank you!

Submission checklist

  • [y] Check that you are running the latest recommended version of LanteaCraft.
  • [y] Check that the issue isn't a known problem already (https://github.com/PC-Logix/LanteaCraft/issues).
  • [y] Check that you can repeat this issue with just LanteaCraft installed.

Expected behavior

No graphical errors.

Actual behavior

Graphical error that either shows either the direction around the block (with doors and DHDs) or highlights an entire area (with Stargate bases).

Steps to reproduce

Open up world and place down either DHD, Stargate base, LanteaCraft door, etc.

System information

  • MinecraftForge version: 10.13.4.1614
  • LanteaCraft version: 1.7.10-23

Solution

Just recompile it. I did not have this issue when I compiled it myself.

@Temmie19
Copy link
Author

Temmie19 commented Dec 6, 2017

Oh. Also doors in that version only place one block high versus the normal two block high.

@AfterLifeLochie
Copy link

AfterLifeLochie commented Dec 7, 2017

I suspect you might have a pair of debugging glasses on, The DebugLayerTileRenderer doesn't do anything unless the following conditions are met:

  • There has to be a player; if not there's no render pipeline right now that's worth debugging
  • The player instance has to have an armorInventory; if it doesn't, wearing is impossible
  • The glasses stack is fetched from the runtime.items() container, is compared against whatever is in any of the player's armor slots (the glasses need not be on the head). It should be noted that even if the container returns null at this stage, the comparison checks the stack itself isn't null first.

From a quick source check DebugLayerTileRenderer (which is generating the artefacts you're probably seeing; see batchRenderAxis, batchRenderClipBox and batchRenderGBox in DebugLayerTileRenderer) is likely responsible but I can't see any reason it could break.

(fwiw, I don't control the compile pipeline, but if you really think this a compile issue then I'd suggest the working environment be purged entirely; a clean fetch of the latest revision is strongly recommended.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants