Merge pull request #948 from PHPCSStandards/feature/generic-lower-uppercaseconstants-support-php84-final-props

PHP 8.4 | Generic/[Lower|Upper]CaseConstant: add support for final properties

Author: jrfnl

src/Standards/Generic/Sniffs/PHP/LowerCaseConstantSniff.php

@@ -77,6 +77,7 @@ public function register()
         $targets[] = T_VAR;
         $targets[] = T_STATIC;
         $targets[] = T_READONLY;
+        $targets[] = T_FINAL;
 
         // Register function keywords to filter out param/return type declarations.
         $targets[] = T_FUNCTION;
@@ -137,6 +138,7 @@ public function process(File $phpcsFile, $stackPtr)
             || $tokens[$stackPtr]['code'] === T_VAR
             || $tokens[$stackPtr]['code'] === T_STATIC
             || $tokens[$stackPtr]['code'] === T_READONLY
+            || $tokens[$stackPtr]['code'] === T_FINAL
         ) {
             $skipOver = (Tokens::$emptyTokens + $this->propertyTypeTokens);
             $skipTo   = $phpcsFile->findNext($skipOver, ($stackPtr + 1), null, true);

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.1.inc

@@ -155,3 +155,8 @@ const MYCONST = TRUE;
 class SkipOverPHP82DNFTypes {
     protected (\FullyQualified&Partially\Qualified)|TRUE $propertyC;
 }
+
+class SkipOverPHP84FinalProperties {
+    final MyType|FALSE $propA;
+    private static final NULL|MyClass $propB;
+}

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.1.inc.fixed

@@ -155,3 +155,8 @@ const MYCONST = true;
 class SkipOverPHP82DNFTypes {
     protected (\FullyQualified&Partially\Qualified)|TRUE $propertyC;
 }
+
+class SkipOverPHP84FinalProperties {
+    final MyType|FALSE $propA;
+    private static final NULL|MyClass $propB;
+}

src/Standards/Generic/Tests/PHP/UpperCaseConstantUnitTest.inc

@@ -100,3 +100,8 @@ $cl = function (int|false $param = null, Type|null $obj = new MyObj(false)) : st
 class SkipOverPHP82DNFTypes {
     protected (\FullyQualified&Partially\Qualified)|false $propertyC;
 }
+
+class SkipOverPHP84FinalProperties {
+    final MyType|false $propA;
+    private static final null|MyClass $propB;
+}

src/Standards/Generic/Tests/PHP/UpperCaseConstantUnitTest.inc.fixed

@@ -100,3 +100,8 @@ $cl = function (int|false $param = NULL, Type|null $obj = new MyObj(FALSE)) : st
 class SkipOverPHP82DNFTypes {
     protected (\FullyQualified&Partially\Qualified)|false $propertyC;
 }
+
+class SkipOverPHP84FinalProperties {
+    final MyType|false $propA;
+    private static final null|MyClass $propB;
+}