Skip to content

Commit 52dd82b

Browse files
committed
Generic/UselessOverridingMethod: improve documentation description and
titles - <documentation> title now matches the sniff title. - <standard> description uses 'discouraged' instead of 'should not' as this sniff raises a warning and not an error. - Minor grammar fixes and small changes to hopefully improve the readability of the <standard> description and <code> titles.
1 parent 389a461 commit 52dd82b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Standards/Generic/Docs/CodeAnalysis/UselessOverridingMethodStandard.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
<documentation title="Useless Overriding Methods">
1+
<documentation title="Useless Overriding Method">
22
<standard>
33
<![CDATA[
4-
Methods should not be defined that only call the parent method.
4+
It is discouraged to override a method if the overriding method only calls the parent method.
55
]]>
66
</standard>
77
<code_comparison>
8-
<code title="Valid: A method that extends functionality on a parent method.">
8+
<code title="Valid: A method that extends functionality of a parent method.">
99
<![CDATA[
1010
final class Foo extends Baz
1111
{
@@ -17,7 +17,7 @@ final class Foo extends Baz
1717
}
1818
]]>
1919
</code>
20-
<code title="Invalid: An overriding method that only calls the parent.">
20+
<code title="Invalid: An overriding method that only calls the parent method.">
2121
<![CDATA[
2222
final class Foo extends Baz
2323
{

0 commit comments

Comments
 (0)