Merge pull request #555 from PHPCSStandards/feature/552-squiz-selfmemberreference-bugfix-close-tag

Squiz/SelfMemberReference: handle namespace declaration ending on PHP close tag

Author: jrfnl

src/Standards/Squiz/Sniffs/Classes/SelfMemberReferenceSniff.php

@@ -225,7 +225,7 @@ protected function getNamespaceOfScope(File $phpcsFile, $stackPtr)
         $namespaceDeclaration = $phpcsFile->findPrevious(T_NAMESPACE, $stackPtr);
 
         if ($namespaceDeclaration !== false) {
-            $endOfNamespaceDeclaration = $phpcsFile->findNext([T_SEMICOLON, T_OPEN_CURLY_BRACKET], $namespaceDeclaration);
+            $endOfNamespaceDeclaration = $phpcsFile->findNext([T_SEMICOLON, T_OPEN_CURLY_BRACKET, T_CLOSE_TAG], $namespaceDeclaration);
             $namespace = $this->getDeclarationNameWithNamespace(
                 $phpcsFile->getTokens(),
                 ($endOfNamespaceDeclaration - 1)

src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc

@@ -172,3 +172,14 @@ namespace Foo /*comment*/ \ Bah {
         }
     }
 }
+
+namespace EndsIn\CloseTag ?>
+<?php
+
+class Baz {
+    function myFunction()
+    {
+        \EndsIn\CloseTag\Whatever::something();
+        \EndsIn\CloseTag\Baz::something();
+    }
+}

src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc.fixed

@@ -160,3 +160,14 @@ namespace Foo /*comment*/ \ Bah {
         }
     }
 }
+
+namespace EndsIn\CloseTag ?>
+<?php
+
+class Baz {
+    function myFunction()
+    {
+        \EndsIn\CloseTag\Whatever::something();
+        self::something();
+    }
+}

src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.php

@@ -46,6 +46,7 @@ public function getErrorList()
             143 => 2,
             162 => 1,
             171 => 1,
+            183 => 1,
         ];
 
     }//end getErrorList()