Add tests for existing sniffs

Author: DanielEScherzer

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.1.inc

@@ -151,3 +151,15 @@ class TypedConstants {
 
 // Global constants can not be typed.
 const MYCONST = TRUE;
+
+// PHP 8.4 asymmetric visibility
+class WithAsym {
+
+    private(set) NULL|TRUE $asym1 = TRUE;
+
+    public private(set) ?bool $asym2 = FALSE;
+
+    protected(set) FALSE|string|null $asym3 = NULL;
+
+    public protected(set) Type|NULL|bool $asym4 = TRUE;
+}

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.1.inc.fixed

@@ -151,3 +151,15 @@ class TypedConstants {
 
 // Global constants can not be typed.
 const MYCONST = true;
+
+// PHP 8.4 asymmetric visibility
+class WithAsym {
+
+    private(set) NULL|TRUE $asym1 = true;
+
+    public private(set) ?bool $asym2 = false;
+
+    protected(set) FALSE|string|null $asym3 = null;
+
+    public protected(set) Type|NULL|bool $asym4 = true;
+}

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php

@@ -66,6 +66,10 @@ public function getErrorList($testFile='')
                 129 => 1,
                 149 => 1,
                 153 => 1,
+                158 => 1,
+                160 => 1,
+                162 => 1,
+                164 => 1,
             ];
 
         case 'LowerCaseConstantUnitTest.js':

src/Standards/PSR12/Tests/Properties/ConstantVisibilityUnitTest.inc

@@ -20,3 +20,15 @@ enum SomeEnum {
     public const BAR = 'bar';
     const BAZ = 'baz';
 }
+
+// Don't break on asymmetric visibility
+class WithAsym {
+
+    private(set) string $asym1;
+
+    public private(set) string $asym2;
+
+    protected(set) string $asym3;
+
+    public protected(set) string $asym4;
+}

src/Standards/PSR2/Tests/Classes/PropertyDeclarationUnitTest.inc

@@ -85,3 +85,17 @@ class ReadOnlyProp {
 
     readonly protected ?string $wrongOrder2;
 }
+
+class AsymmetricVisibility {
+    private(set) int $foo,
+        $bar,
+        $var = 5;
+
+    public private(set) readonly ?string    $spaces;
+
+    protected(set) array $unfixed;
+
+    protected(set) public int $wrongOrder1;
+
+    private(set) protected ?string $wrongOrder2;
+}

src/Standards/PSR2/Tests/Classes/PropertyDeclarationUnitTest.inc.fixed

@@ -82,3 +82,17 @@ class ReadOnlyProp {
 
     protected readonly ?string $wrongOrder2;
 }
+
+class AsymmetricVisibility {
+    private(set) int $foo,
+        $bar,
+        $var = 5;
+
+    public private(set) readonly ?string $spaces;
+
+    protected(set) array $unfixed;
+
+    public protected(set) int $wrongOrder1;
+
+    protected private(set) ?string $wrongOrder2;
+}

src/Standards/PSR2/Tests/Classes/PropertyDeclarationUnitTest.php

@@ -31,31 +31,36 @@ final class PropertyDeclarationUnitTest extends AbstractSniffUnitTest
     public function getErrorList()
     {
         return [
-            7  => 1,
-            9  => 2,
-            10 => 1,
-            11 => 1,
-            17 => 1,
-            18 => 1,
-            23 => 1,
-            38 => 1,
-            41 => 1,
-            42 => 1,
-            50 => 2,
-            51 => 1,
-            55 => 1,
-            56 => 1,
-            61 => 1,
-            62 => 1,
-            68 => 1,
-            69 => 1,
-            71 => 1,
-            72 => 1,
-            76 => 1,
-            80 => 1,
-            82 => 1,
-            84 => 1,
-            86 => 1,
+            7   => 1,
+            9   => 2,
+            10  => 1,
+            11  => 1,
+            17  => 1,
+            18  => 1,
+            23  => 1,
+            38  => 1,
+            41  => 1,
+            42  => 1,
+            50  => 2,
+            51  => 1,
+            55  => 1,
+            56  => 1,
+            61  => 1,
+            62  => 1,
+            68  => 1,
+            69  => 1,
+            71  => 1,
+            72  => 1,
+            76  => 1,
+            80  => 1,
+            82  => 1,
+            84  => 1,
+            86  => 1,
+            90  => 1,
+            94  => 1,
+            96  => 1,
+            98  => 1,
+            100 => 1,
         ];
 
     }//end getErrorList()