From 3835a87bdcbd5d3db7a9d08367034afe48904830 Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Wed, 20 Dec 2023 15:26:55 -0300 Subject: [PATCH 1/4] Generic/LanguageConstructSpacing: add XML documentation --- .../LanguageConstructSpacingStandard.xml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml diff --git a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml new file mode 100644 index 0000000000..1ac862dbed --- /dev/null +++ b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml @@ -0,0 +1,24 @@ + + + + + + + 'Hello, World!'; +throw new Exception(); +return $newLine; + ]]> + + + 'Hello, World!'; +throw new Exception(); +return +$newLine; + ]]> + + + From 7bd73250092b973f39e841237c945c872f991028 Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Tue, 2 Jan 2024 14:45:16 -0300 Subject: [PATCH 2/4] LanguageConstructSpacing: improve sniff description in the documentation This commit improves the description of the LanguageConstructSpacing sniff in the documentation by describing which types of language constructs are affected by this sniff instead of listing all affected language constructs. --- .../Docs/WhiteSpace/LanguageConstructSpacingStandard.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml index 1ac862dbed..56ed023dc7 100644 --- a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml +++ b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml @@ -1,7 +1,7 @@ From dac279db222989498e2b478374455f3bbc556c75 Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Tue, 2 Jan 2024 15:16:20 -0300 Subject: [PATCH 3/4] LanguageConstructSpacing: improve doc by adding `yield from` examples This commit improves the documentation by adding another and blocks to document how the sniff behaves when handling the `yield from` expression. --- .../LanguageConstructSpacingStandard.xml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml index 56ed023dc7..886f2f09f4 100644 --- a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml +++ b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml @@ -21,4 +21,24 @@ $newLine; ]]> + + + + + + from [1, 2, 3]; + ]]> + + + from [1, 2, 3]; +yield from [1, 2, 3]; +yield +from [1, 2, 3]; + ]]> + + From fd0793027092732b371ae453e1b4f6a95df6712c Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Wed, 3 Jan 2024 14:41:49 -0300 Subject: [PATCH 4/4] Improve LanguageConstructSpacing description in the docs Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com> --- .../Docs/WhiteSpace/LanguageConstructSpacingStandard.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml index 886f2f09f4..a9cd5a65cb 100644 --- a/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml +++ b/src/Standards/Generic/Docs/WhiteSpace/LanguageConstructSpacingStandard.xml @@ -1,7 +1,7 @@