From a6e88975a99aed4967ff51dbcd3765dff3ec1644 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20=C5=BDoljom?= Date: Mon, 8 Jan 2024 15:25:58 +0100 Subject: [PATCH 1/4] Add the documentation for the PSR12 Constant Visiblity sniff --- .../Properties/ConstantVisibilityStandard.xml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml diff --git a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml new file mode 100644 index 0000000000..fb5e037784 --- /dev/null +++ b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml @@ -0,0 +1,25 @@ + + + + + + + private const BAR = 'bar'; +} + ]]> + + + const BAR = 'bar'; +} + ]]> + + + From 5140adaf55213be00cf001ee9e0638b3d81bc479 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20=C5=BDoljom?= Date: Fri, 12 Jan 2024 10:40:23 +0100 Subject: [PATCH 2/4] Update the documentation according to the review --- .../PSR12/Docs/Properties/ConstantVisibilityStandard.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml index fb5e037784..4bcfce245d 100644 --- a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml +++ b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml @@ -1,7 +1,7 @@ @@ -9,7 +9,7 @@ private const BAR = 'bar'; + private const BAR = 'bar'; } ]]> @@ -17,7 +17,7 @@ class Foo const BAR = 'bar'; + const BAR = 'bar'; } ]]> From 6287357e00a610b9f4f58b8299d98203a8f42007 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20=C5=BDoljom?= Date: Fri, 12 Jan 2024 17:57:24 +0100 Subject: [PATCH 3/4] Update the documentation description --- .../PSR12/Docs/Properties/ConstantVisibilityStandard.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml index 4bcfce245d..17de1046fc 100644 --- a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml +++ b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml @@ -2,6 +2,8 @@ From 5803a4adcbe1c16eb5cac2c499085b445e3f0ebc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20=C5=BDoljom?= Date: Sat, 13 Jan 2024 06:37:43 +0100 Subject: [PATCH 4/4] Update ConstantVisibilityStandard.xml Add enums to the 'class' list --- .../PSR12/Docs/Properties/ConstantVisibilityStandard.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml index 17de1046fc..da9b60a404 100644 --- a/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml +++ b/src/Standards/PSR12/Docs/Properties/ConstantVisibilityStandard.xml @@ -3,7 +3,7 @@