Experiment to replace the large "unstructured" array of Excel function signature definitions with a structured collection of Value Objects to see what affect it has on memory usage and speed.

This isn't a perfect implementation yet: but it's enough to take a look at the memory usage and speed.

Author: MarkBaker

.phpcs.xml.dist

@@ -19,4 +19,8 @@
     <rule ref="PSR12">
         <exclude name="PSR2.Methods.MethodDeclaration.Underscore"/>
     </rule>
+
+    <rule ref="Squiz.Classes.ValidClassName.NotCamelCaps">
+        <exclude-pattern>*/src/PhpSpreadsheet/Calculation/Engine/Functions/*</exclude-pattern>
+    </rule>
 </ruleset>

bin/generate-locales

@@ -7,10 +7,7 @@ use PhpOffice\PhpSpreadsheetInfra\LocaleGenerator;
 require_once 'vendor/autoload.php';
 
 try {
-    $phpSpreadsheetFunctionsProperty = (new ReflectionClass(Calculation::class))
-        ->getProperty('phpSpreadsheetFunctions');
-    $phpSpreadsheetFunctionsProperty->setAccessible(true);
-    $phpSpreadsheetFunctions = $phpSpreadsheetFunctionsProperty->getValue();
+    $phpSpreadsheetFunctions = Calculation::getInstance()->getFunctions();
 
     $localeGenerator = new LocaleGenerator(
         realpath(__DIR__ . '/../src/PhpSpreadsheet/Calculation/locale/'),

infra/LocaleGenerator.php

@@ -3,6 +3,7 @@
 namespace PhpOffice\PhpSpreadsheetInfra;
 
 use Exception;
+use PhpOffice\PhpSpreadsheet\Calculation\Engine\ExcelFunctions;
 use PhpOffice\PhpSpreadsheet\Cell\Cell;
 use PhpOffice\PhpSpreadsheet\IOFactory;
 use PhpOffice\PhpSpreadsheet\Spreadsheet;
@@ -37,6 +38,9 @@ class LocaleGenerator
      */
     protected $translationBaseFolder;
 
+    /**
+     * @var ExcelFunctions
+     */
     protected $phpSpreadsheetFunctions;
 
     /**
@@ -67,7 +71,7 @@ class LocaleGenerator
     public function __construct(
         string $translationBaseFolder,
         string $translationSpreadsheetName,
-        array $phpSpreadsheetFunctions,
+        ExcelFunctions $phpSpreadsheetFunctions,
         bool $verbose = false
     ) {
         $this->translationBaseFolder = $translationBaseFolder;
@@ -146,7 +150,7 @@ protected function buildFunctionsFileForLocale($column, $locale): void
             $translationValue = $translationCell->getValue();
             if ($this->isFunctionCategoryEntry($translationCell)) {
                 $this->writeFileSectionHeader($functionFile, "{$translationValue} ({$functionName})");
-            } elseif (!array_key_exists($functionName, $this->phpSpreadsheetFunctions)) {
+            } elseif (!$this->phpSpreadsheetFunctions->isRecognisedExcelFunction($functionName)) {
                 $this->log("Function {$functionName} is not defined in PhpSpreadsheet");
             } elseif (!empty($translationValue)) {
                 $functionTranslation = "{$functionName} = {$translationValue}" . self::EOL;

phpstan-baseline.neon

@@ -215,11 +215,6 @@ parameters:
 			count: 1
 			path: src/PhpSpreadsheet/Calculation/Calculation.php
 
-		-
-			message: "#^Property PhpOffice\\\\PhpSpreadsheet\\\\Calculation\\\\Calculation\\:\\:\\$phpSpreadsheetFunctions has no type specified\\.$#"
-			count: 1
-			path: src/PhpSpreadsheet/Calculation/Calculation.php
-
 		-
 			message: "#^Property PhpOffice\\\\PhpSpreadsheet\\\\Calculation\\\\Calculation\\:\\:\\$returnArrayAsType has no type specified\\.$#"
 			count: 1