Skip to content

Phpstan Tweaks#4439

Merged
oleibman merged 4 commits into
PHPOffice:masterfrom
oleibman:stan1001
Apr 17, 2025
Merged

Phpstan Tweaks#4439
oleibman merged 4 commits into
PHPOffice:masterfrom
oleibman:stan1001

Conversation

@oleibman
Copy link
Copy Markdown
Collaborator

@oleibman oleibman commented Apr 7, 2025

Phpstan level 10 reports an enormous number of errors. So does the excluded missingType.iterableValue. I do not plan to introduce either any time soon. But I will submit piecemeal changes from time to time. Changes will be mostly limited to phpdoc type declarations.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • code quality

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

oleibman added 4 commits April 6, 2025 18:14
Phpstan level 10 reports an enormous number of errors. So does the excluded missingType.iterableValue. I do not plan to introduce either any time soon. But I will submit piecemeal changes from time to time. Changes will be mostly limited to phpdoc type declarations.
@oleibman oleibman added this pull request to the merge queue Apr 17, 2025
Merged via the queue into PHPOffice:master with commit e831636 Apr 17, 2025
14 checks passed
@oleibman oleibman deleted the stan1001 branch April 18, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant