Optimize ReferenceHelper to filter cells by range before iterating#4826
Draft
kemo wants to merge 5 commits into
Draft
Optimize ReferenceHelper to filter cells by range before iterating#4826kemo wants to merge 5 commits into
kemo wants to merge 5 commits into
Conversation
Contributor
Author
Benchmark Results (reference-helper-cell-index)Targeted benchmark: insert rows/columns into worksheets of increasing size, with formulas.
Marginal improvement (2–6%) at larger sheet sizes. Within noise for smaller sheets. Memory usage unchanged. |
Collaborator
|
Thank you for the summaries. For purposes of prioritization, I am going to put the PRs with less demonstrable improvement, including this one, in draft status for now. This does not mean that I will not return to them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCoordinatesInRange()andgetCoordinatesOutsideRange()methods toCells.phpthat filter cells using the internal index arrayinsertNewBefore()inReferenceHelper.phpfrom a single loop over ALL cells to two targeted passes: one for affected cells (move) and one for outside cells (formula update only)Changes
src/PhpSpreadsheet/Collection/Cells.php: AddedgetCoordinatesInRange()andgetCoordinatesOutsideRange()src/PhpSpreadsheet/ReferenceHelper.php: Two-pass refactor ofinsertNewBefore()tests/PhpSpreadsheetTests/ReferenceHelper6Test.php: 14 new tests covering row/column insert, formula updates, edge casestests/PhpSpreadsheetTests/Benchmark/ReferenceHelperBenchmark.php: Benchmark with 10,000 cells, indexed vs full iteration comparisonTest plan
vendor/bin/phpunit --group benchmark --filter ReferenceHelperBenchmark --stderr