Skip to content

Optimize XLS (BIFF8) reader performance with reduced per-cell overhead #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kemo wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimize XLS (BIFF8) reader performance with reduced per-cell overhead #4833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ae5eee
Optimize XLS reader performance
kemo Mar 11, 2026
9c3b7ca
Fix PHPStan errors: cast min() to int for substr, remove redundant re…
kemo Mar 11, 2026
607eb88
Use chunk_split instead of str_split+implode to reduce peak memory
kemo Mar 12, 2026
972cbe8
Add XLS reader benchmark tests
kemo Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@
"autoload-dev": {
"psr-4": {
"PhpOffice\\PhpSpreadsheetTests\\": "tests/PhpSpreadsheetTests",
"PhpOffice\\PhpSpreadsheetInfra\\": "infra"
"PhpOffice\\PhpSpreadsheetInfra\\": "infra",
"PhpOffice\\PhpSpreadsheetBenchmarks\\": "tests/Benchmark"
}
}
}
13 changes: 9 additions & 4 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" bootstrap="./tests/bootstrap.php" backupGlobals="true" colors="true" cacheResultFile="/tmp/.phpspreadsheet.phpunit.result.cache">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" bootstrap="./tests/bootstrap.php" backupGlobals="true" colors="true" cacheResultFile="/tmp/.phpspreadsheet.phpunit.result.cache" defaultTestSuite="PhpSpreadsheet Unit Test Suite">
<coverage/>
<php>
<ini name="memory_limit" value="2048M"/>
<ini name="error_reporting" value="E_ALL"/>
</php>
<testsuite name="PhpSpreadsheet Unit Test Suite">
<directory>./tests/PhpSpreadsheetTests</directory>
</testsuite>
<testsuites>
<testsuite name="PhpSpreadsheet Unit Test Suite">
<directory>./tests/PhpSpreadsheetTests</directory>
</testsuite>
<testsuite name="Benchmark">
<directory>./tests/Benchmark</directory>
</testsuite>
</testsuites>
<source>
<include>
<directory suffix=".php">./src</directory>
Expand Down
13 changes: 13 additions & 0 deletions src/PhpSpreadsheet/Cell/Cell.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,19 @@ public function setXfIndex(int $indexValue): self
return $this->updateInCollection();
}

/**
* Set the XF index without triggering updateInCollection().
*
* This is intended for use by readers that will immediately follow with
* setValueExplicit(), avoiding a redundant cache write.
*
* @internal
*/
public function setXfIndexNoUpdate(int $indexValue): void
{
$this->xfIndex = $indexValue;
}

/**
* Set the formula attributes.
*
Expand Down
Loading
Loading