Skip to content

Html Writer Apply Rotation To Images#4877

Open
oleibman wants to merge 1 commit into
PHPOffice:masterfrom
oleibman:issue4875
Open

Html Writer Apply Rotation To Images#4877
oleibman wants to merge 1 commit into
PHPOffice:masterfrom
oleibman:issue4875

Conversation

@oleibman
Copy link
Copy Markdown
Collaborator

Fix #4875. If rotation is applied to a Drawing, Html Writer will now generate the appropriate Css. This will cause the image to be rotated for Html, Dompdf, and Mpdf; Tcpdf does not recognize the rotation Css.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Fix PHPOffice#4875. If rotation is applied to a Drawing, Html Writer will now generate the appropriate Css. This will cause the image to be rotated for Html, Dompdf, and Mpdf; Tcpdf does not recognize the rotation Css.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

用Drawing来添加图片,并生成html,setRotation()未生效

1 participant