Skip to content

Commit 4cc00a3

Browse files
gnpricePIG208
authored andcommitted
internal_link test [nfc]: Give test groups distinct names
The organization of this code's test cases is a bit scattered; partly because they were ported from tests written for the legacy zulip-mobile RN app, which themselves accumulated in layers over time. (After all, one doesn't want to drop one of these tests in a refactoring unless taking the time to be sure its substance is covered by a surviving test.) It's potentially confusing having several groups with the same name, though. Fix that by picking different names for all but one of them. The name collision was originally noted by Zixuan in zulip#1059.
1 parent c5f1cd4 commit 4cc00a3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/model/internal_link_test.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ void main() {
5555
}
5656
}
5757

58-
group('parseInternalLink', () {
58+
group('parseInternalLink is-internal', () {
5959
final streams = [
6060
eg.stream(streamId: 1, name: 'check'),
6161
];
@@ -398,7 +398,7 @@ void main() {
398398
});
399399
});
400400

401-
group('parseInternalLink', () {
401+
group('parseInternalLink again', () { // TODO perhaps unify with tests above
402402
group('topic link parsing', () {
403403
final stream = eg.stream(name: "general");
404404

0 commit comments

Comments
 (0)