Skip to content

Commit c1fcf2d

Browse files
authored
test: fix tests failed after prqlc 0.13.4 (#357)
1 parent dc0af75 commit c1fcf2d

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

DESCRIPTION

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ RoxygenNote: 7.3.2
3535
SystemRequirements: Cargo (Rust's package manager), rustc
3636
VignetteBuilder: knitr
3737
Config/testthat/edition: 3
38+
Config/testthat/parallel: true
3839
Config/Needs/dev:
3940
brio,
4041
devtools,

tests/testthat/_snaps/compile.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,21 @@
3939
Condition
4040
Error:
4141
! Error:
42-
╭─[ :1:23 ]
42+
╭─[:1:23]
4343
4444
1 │ Mississippi has four S’s and four I’s.
4545
│ ┬
4646
│ ╰── unexpected ’
4747
───╯
4848
Error:
49-
╭─[ :1:36 ]
49+
╭─[:1:36]
5050
5151
1 │ Mississippi has four S’s and four I’s.
5252
│ ┬
5353
│ ╰── unexpected ’
5454
───╯
5555
Error:
56-
╭─[ :1:39 ]
56+
╭─[:1:39]
5757
5858
1 │ Mississippi has four S’s and four I’s.
5959
│ │
@@ -67,7 +67,7 @@
6767
Condition
6868
Error:
6969
! Error:
70-
╭─[ :1:17 ]
70+
╭─[:1:17]
7171
7272
1 │ from a | select [b]
7373
│ ─┬─
@@ -81,7 +81,7 @@
8181
Condition
8282
Error:
8383
! Error:
84-
╭─[ :1:21 ]
84+
╭─[:1:21]
8585
8686
1 │ from a | select {{{b
8787
│ │
@@ -389,7 +389,7 @@
389389
tryCatch(prql_compile(query, format = TRUE, display = display), error = function(
390390
e) cli::ansi_html(e))
391391
Output
392-
[1] "Error: Error:\n ╭─[ :3:1 ]\n │\n 3 │ select\n │ ───┬──\n │ ╰──── main expected type `relation`, but found type `func relation -> relation`\n │\n │ Help: Have you forgotten an argument to function std.select?\n │\n │ Note: Type `relation` expands to `[{..}]`\n───╯\n\n"
392+
[1] "Error: Error:\n ╭─[:3:1]\n │\n 3 │ select\n │ ───┬──\n │ ╰──── main expected type `relation`, but found type `func relation -> relation`\n │\n │ Help: Have you forgotten an argument to function std.select?\n │\n │ Note: Type `relation` expands to `[{..}]`\n───╯\n\n"
393393

394394
# display display=bar
395395

tests/testthat/test-compile.R

-3
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ test_that("PRQL query", {
7171

7272
patrick::with_parameters_test_that("Syntax error",
7373
{
74-
# TODO: These snap shot tests will fail on GHA with ariadne 0.5.0 but pass with aridane 0.5.1.
75-
skip_on_ci()
7674
expect_snapshot(
7775
cat(prql_compile(query, "sql.any", format = TRUE, signature_comment = FALSE)),
7876
error = TRUE
@@ -114,7 +112,6 @@ from foo
114112
select
115113
"
116114
skip_if_not_installed("cli")
117-
skip_on_ci()
118115
expect_snapshot(
119116
tryCatch(prql_compile(query, format = TRUE, display = display), error = \(e) cli::ansi_html(e))
120117
)

0 commit comments

Comments
 (0)