[CI][BugFix] Adapt test_token_penalty to Paddle uniform float16 behavior change#8031
Merged
Merged
Conversation
Collaborator
Author
|
/skip-ci ci_iluvatar |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8031 +/- ##
==========================================
Coverage ? 77.78%
==========================================
Files ? 404
Lines ? 57430
Branches ? 9032
==========================================
Hits ? 44674
Misses ? 9907
Partials ? 2849
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZhangYulongg
approved these changes
Jun 10, 2026
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tests/operators/test_token_penalty.pyfails after changes introduced in Paddle PR #79130, which modifiedUniformKernelbehavior forfloat16precision.Previously,
paddle.randinfloat16could produce values extremely close to1.0due to casting fromfloat32. The test assumptions were based on this behavior.After the fix in Paddle:
max (1.0)afterfloat16cast,min (0.0)to strictly enforce the half-open interval[0, 1).As a result, under fixed seed
2023, some logits that were previously non-zero now become0.0.This breaks the test assertion logic, which did not account for valid zero-valued logits.
Modifications
tests/operators/test_token_penalty.pyto adapt to newfloat16uniform sampling behavior.0.0.UniformKernel.Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.