Skip to content

Commit

Permalink
usage on bad network
Browse files Browse the repository at this point in the history
ERROR    parsl.process_loggers:process_loggers.py:30 Exceptional ending for cleanup on thread MainThread
Traceback (most recent call last):
  File "/home/benc/parsl/src/parsl/parsl/process_loggers.py", line 26, in wrapped
    r = func(*args, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^
  File "/home/benc/parsl/src/parsl/parsl/dataflow/dflow.py", line 1262, in cleanup
    self.usage_tracker.close()
  File "/home/benc/parsl/src/parsl/parsl/usage_tracking/usage.py", line 231, in close
    proc.close()
  File "/usr/local/lib/python3.12/multiprocessing/process.py", line 181, in close
    raise ValueError("Cannot close a process while it is still running. "
ValueError: Cannot close a process while it is still running. You should first call join() or terminate().

on my laptop when in a dev container with weird networking (aka network connections hang rather than connect... which probably means usage code is sitting inside some OS call?)
  • Loading branch information
benclifford committed Jul 18, 2024
1 parent 2c19a8f commit be9b116
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions parsl/usage_tracking/usage.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,5 +227,7 @@ def close(self, timeout: float = 10.0) -> None:
if proc.is_alive():
logger.warning("Usage tracking process did not end itself; sending SIGKILL")
proc.kill()
logger.warning("Joining on killed usage tracking process")
proc.join()

proc.close()

0 comments on commit be9b116

Please sign in to comment.