Fix Poisonburst Arrow not scaling with Skill Effect Duration (#1107)

When we changed the ailment calcs we removed support for the the skill duration overriding bases poison duration mods
This PR also adds support for CalcSections to use SkillData mods as conditionals to display sections

Co-authored-by: LocalIdentity <[email protected]>

Author: LocalIdentity

src/Classes/CalcsTab.lua

@@ -396,9 +396,13 @@ end
 function CalcsTabClass:CheckFlag(obj)
 	local actor = self.input.showMinion and self.calcsEnv.minion or self.calcsEnv.player
 	local skillFlags = actor.mainSkill.activeEffect.statSetCalcs.skillFlags
+	local skillData = actor.mainSkill.skillData
 	if obj.flag and not skillFlags[obj.flag] then
 		return
 	end
+	if obj.skillData and not skillData[obj.skillData] then
+		return
+	end
 	if obj.flagList then
 		for _, flag in ipairs(obj.flagList) do
 			if not skillFlags[flag] then
@@ -412,6 +416,9 @@ function CalcsTabClass:CheckFlag(obj)
 	if obj.notFlag and skillFlags[obj.notFlag] then
 		return
 	end
+	if obj.notSkillData and skillData[obj.notSkillData] then
+		return
+	end
 	if obj.notFlagList then
 		for _, flag in ipairs(obj.notFlagList) do
 			if skillFlags[flag] then

src/Modules/CalcOffence.lua

@@ -4322,8 +4322,9 @@ function calcs.offence(env, actor, activeSkill)
 				ailmentTypeMod = ailmentDamageType
 			end
 			local rateMod = (calcLib.mod(skillModList, cfg, ailment .. "Faster") + enemyDB:Sum("INC", nil, "Self" .. ailment .. "Faster") / 100)  / calcLib.mod(skillModList, cfg, ailment .. "Slower")
-			local durationBase = env.modDB:Override(nil, ailment .. "DurationBase") or data.misc[ailment .. "DurationBase"]
-			local durationMod = m_max(calcLib.mod(skillModList, dotCfg, "Enemy" .. ailment .. "Duration", "EnemyAilmentDuration", "Enemy" .. ailmentTypeMod .. "AilmentDuration", "SkillAndDamagingAilmentDuration") * calcLib.mod(enemyDB, nil, "Self" .. ailment .. "Duration", "SelfAilmentDuration", "Self" .. ailmentTypeMod .. "AilmentDuration"), 0)
+			local durationBase = skillData[ailment:lower() .. "DurationIsSkillDuration"] and skillData.duration or env.modDB:Override(nil, ailment .. "DurationBase") or data.misc[ailment .. "DurationBase"]
+			local durationMod = m_max(calcLib.mod(skillModList, dotCfg, "Enemy" .. ailment .. "Duration", "EnemyAilmentDuration", "Enemy" .. ailmentTypeMod .. "AilmentDuration", "SkillAndDamagingAilmentDuration", skillData[ailment:lower() .. "DurationIsSkillDuration"] and
+				"Duration" or nil) * calcLib.mod(enemyDB, nil, "Self" .. ailment .. "Duration", "SelfAilmentDuration", "Self" .. ailmentTypeMod .. "AilmentDuration"), 0)
 			durationMod = m_max(durationMod, 0)
 			globalOutput[ailment .. "Duration"] = durationBase * durationMod / rateMod * debuffDurationMult
 

src/Modules/CalcSections.lua

@@ -996,7 +996,8 @@ return {
 	{ label = "Caustic Ground", haveOutput = "CausticGroundFromPoison", { format = "{0:output:CausticGroundDPS}", { breakdown = "CausticGroundDPS" } } },
 	{ label = "Poison Duration", { format = "{2:output:PoisonDuration}s",
 		{ breakdown = "PoisonDuration" },
-		{ label = "Player modifiers", modName = { "EnemyPoisonDuration", "EnemyAilmentDuration", "SkillAndDamagingAilmentDuration", "PoisonFaster" }, cfg = "poison" },
+		{ label = "Player modifiers", notSkillData = "poisonDurationIsSkillDuration", modName = { "EnemyPoisonDuration", "EnemyAilmentDuration", "SkillAndDamagingAilmentDuration", "PoisonFaster" }, cfg = "poison" },
+		{ label = "Player modifiers", skillData = "poisonDurationIsSkillDuration", modName = { "EnemyPoisonDuration", "EnemyAilmentDuration", "SkillAndDamagingAilmentDuration", "PoisonFaster", "Duration" }, cfg = "poison" },
 		{ label = "Enemy modifiers", modName = { "SelfPoisonDuration", "SelfAilmentDuration", "SelfPoisonFaster" }, enemy = true },
 	}, },
 	{ label = "Dmg. of all Poisons", { format = "{1:output:PoisonDamage}",