fix elevator

Author: Hadizah454

src/main/java/frc/robot/subsystems/Elevator.java

@@ -13,24 +13,29 @@ public class Elevator extends SubsystemBase {
     public Elevator() {
         elevator = new Neo(9);
         elevator.setPID(0.1, 0, 0); // 😳
+        elevator.setSoftLimit(null, 0);
     }
 
     @Override
     public void periodic() {
       // CommandScheduler.getInstance().run(); //This method will be called once per scheduler run
     }
 
-   
-    public Command motionUp(){
-            return runOnce(() -> elevator.set(0.5));
+    private Command moveUpOrDown(boolean goingUp) {
+        elevator.getPosition();
+        if (goingUp) {
+            return runOnce(() -> elevator.setPosition(0.8));
+        }
+        else {
+            return runOnce(() -> elevator.set(0));
+        }
     }
-
-    public Command motionDown(){
-            return runOnce(() -> elevator.set(-0.5));
+   
+    public Command motionUp() {
+        return moveUpOrDown(true);
     }
-    public void limits(){
-        double maxlimit = elevator.setrotation(0.8);
-        double minlimit = elevator.setrotation(1.0);
+    
+    public Command motionDown() {
+        return moveUpOrDown(false);
     }
-
 }