Skip to content

Commit 13bf6dc

Browse files
authored
Merge pull request #1222 from Patternslib/pat-inject-modernization
pat-inject code optimizations
2 parents a28a386 + 8a3af53 commit 13bf6dc

File tree

3 files changed

+182
-138
lines changed

3 files changed

+182
-138
lines changed

Diff for: src/core/dom.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const toNodeArray = (nodes) => {
6060
* @returns {Array} - The DOM nodes found.
6161
*/
6262
const querySelectorAllAndMe = (el, selector) => {
63-
if (!el) {
63+
if (!el || !el.querySelectorAll) {
6464
return [];
6565
}
6666

Diff for: src/core/dom.test.js

+9
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,15 @@ describe("core.dom tests", () => {
174174

175175
done();
176176
});
177+
178+
it("return empty list, if the element is not a real element.", (done) => {
179+
const res = dom.querySelectorAllAndMe("text", ".selector");
180+
expect(Array.isArray(res)).toBe(true);
181+
expect(res.length).toBe(0);
182+
183+
done();
184+
});
185+
177186
});
178187

179188
describe("wrap tests", () => {

0 commit comments

Comments
 (0)