Skip to content

Commit 606e2ec

Browse files
authored
Merge pull request #1216 from Patternslib/thet-improvements--devserver
Thet improvements devserver
2 parents 3191eba + fadd5d4 commit 606e2ec

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ which contains Patterns and all its dependencies:
4747

4848
Alternatively, you can [download a bundle at patternslib.com](http://patternslib.com/download.html).
4949

50+
To start the development server, use `make serve` or `npx yarn start` and access the demo pages via [http://localhost:3001/](http://localhost:3001/).
51+
The files are watched and the bundle re-built on changes.
52+
You can access the bundle directly at [http://localhost:3001/bundle.min.js](http://localhost:3001/bundle.min.js).
53+
5054

5155
## Layout
5256

@@ -70,7 +74,7 @@ You'll need to have a Sass compiler installed.
7074
To demo the patterns, simply type `make serve` to install the necessary
7175
dependencies and to start a simple Node.js HTTP server.
7276

73-
You can then visit http://localhost:4001 to see a site with demos.
77+
You can then visit http://localhost:3001 to see a site with demos.
7478

7579
Alternatively, patterns can also be demoed through the
7680
[Patternslib.com](http://patternslib.com) website, which is open-source. The

docs/developer/module-federation.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ For jQuery the remote bundle is named ``jquery-remote.min.js``.
2929

3030
```
3131
import "@patternslib/patternslib/webpack/module_federation";
32-
// Please not the parentheses for the next import.
33-
// Kepp them, otherwise we get this error:
32+
// Please note the parentheses for the next import.
33+
// Keep them, otherwise we get this error:
3434
// "Shared module is not available for eager consumption."
3535
import("./src/patterns");
3636
```
@@ -39,8 +39,8 @@ For the jQuery bundle which we will use as remote we create: ``index-jquery.js``
3939

4040
```
4141
import "@patternslib/patternslib/webpack/module_federation";
42-
// Please not the parentheses for the next import.
43-
// Kepp them, otherwise we get this error:
42+
// Please note the parentheses for the next import.
43+
// Keep them, otherwise we get this error:
4444
// "Shared module is not available for eager consumption."
4545
import("@patternslib/patternslib/src/globals");
4646
```

webpack/webpack.config.js

+2
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ module.exports = () => {
8383

8484
if (process.env.NODE_ENV === "development") {
8585
config.devServer.static.directory = path.resolve(__dirname, "../");
86+
config.devServer.watchFiles = ["src/"];
87+
config.devServer.port = "3001";
8688
// Add a strict Content-Security-Policy without 'unsafe-inline' to the dev
8789
// server for testing CSR issues.
8890
//config.devServer.headers["Content-Security-Policy"] =

0 commit comments

Comments
 (0)