Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher updates UI in non-gui(main) thread. #161

Open
Leon-Leyang opened this issue Apr 16, 2023 · 1 comment
Open

Launcher updates UI in non-gui(main) thread. #161

Leon-Leyang opened this issue Apr 16, 2023 · 1 comment
Assignees
@Leon-Leyang
Labels
future-work launcher

Comments

@Leon-Leyang
Copy link
Collaborator

Leon-Leyang commented Apr 16, 2023 •
edited
Loading

Unfortunately the exception has not been catched. However, during the investigation, it is found that updating the GUI from non-gui(main) thread, which the code of the launcher does a lot currently, is considered a bad practice and might cause a crash randomly. Thus, the code will be refactored to avoid such operations in the next release.

Originally posted by @Leon-Leyang in #126 (comment)
@Leon-Leyang Leon-Leyang self-assigned this Apr 16, 2023
@Leon-Leyang
Copy link
Collaborator Author

Apart from the crash issue, sometimes the launcher can not output correctly, with some of the characters missing. This might also be due to updating the UI in non-gui(main) thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leon-Leyang Leon-Leyang

Labels
future-work launcher
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Leon-Leyang