x/axelarcork/keeper, x/cork/keeper: HandleRemoveManagedCellarsProposal should bail out immediately found=true to avoid needless/wasted iterations

[odeke-em]

Summary of Bug

The loops here

sommelier/x/cork/keeper/proposal_handler.go

Lines 62 to 70 in 3157d97

	for _, inputID := range p.CellarIds.Ids {
	if existingID == common.HexToAddress(inputID) {
	found = true
	}
	}
	if !found {
	outputCellarIDs.Ids = append(outputCellarIDs.Ids, existingID.String())
	}

and

sommelier/x/axelarcork/keeper/proposal_handler.go

Lines 41 to 47 in 3157d97

	for _, proposedCellarID := range p.CellarIds.Ids {
	proposedCellarAddress := common.HexToAddress(proposedCellarID)
	found := false
	for _, id := range cellarAddresses {
	if id == proposedCellarAddress {
	found = true
	}

iterate looking for a specific target but once it has found it just keeps iterating and comparing over all all the cellar ids and at no point do we modify found=false in the loop. If we notice down below, we only append to the slice if !found hence we really should just end that loop immediately to avoid needless CPU cycles being wasted

Suggestion

 for _, inputID := range p.CellarIds.Ids { 
 	if existingID == common.HexToAddress(inputID) { 
 		found = true // We found the existing inputID
                 break
 	} 
 } 
  
 if !found { 
 	outputCellarIDs.Ids = append(outputCellarIDs.Ids, existingID.String()) 
 }