Skip to content

Commit 5b6d25c

Browse files
committed
Merge check_prereqs and check_PREREQ_FATAL
1 parent 4037749 commit 5b6d25c

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

lib/ExtUtils/MakeMaker.pm

+12-18
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,7 @@ sub new {
440440
check_manifest();
441441
}
442442
$self->check_min_perl_version;
443-
my $unsatisfied_prereqs = $self->check_prereqs($cmrstash);
444-
$self->check_PREREQ_FATAL($unsatisfied_prereqs); # after ARGV processed
443+
$self->check_prereqs($cmrstash); # must be after ARGV processed
445444
# CONFIGURE after PREREQ_FATAL so can rely on prereqs being present
446445
my ($initial_att, $configure_att) = $self->extract_CONFIGURE;
447446
$self->arch_check(
@@ -456,21 +455,6 @@ sub new {
456455
$self;
457456
}
458457

459-
sub check_PREREQ_FATAL {
460-
my ($self, $unsatisfied_prereqs) = @_;
461-
# RT#91540 PREREQ_FATAL not recognized on command line
462-
if (%$unsatisfied_prereqs && $self->{PREREQ_FATAL}){
463-
my $failedprereqs = join "\n", map {" $_ $unsatisfied_prereqs->{$_}"}
464-
sort { $a cmp $b } keys %$unsatisfied_prereqs;
465-
die <<"END";
466-
MakeMaker FATAL: prerequisites not found.
467-
$failedprereqs
468-
469-
Please install these modules first and rerun 'perl Makefile.PL'.
470-
END
471-
}
472-
}
473-
474458
sub extract_CONFIGURE {
475459
my ($self) = @_;
476460
my %initial_att = %$self; # record initial attributes
@@ -712,7 +696,17 @@ $failedprereqs
712696
Please install these modules first and rerun 'perl Makefile.PL'.
713697
END
714698
}
715-
\%unsatisfied;
699+
# RT#91540 PREREQ_FATAL not recognized on command line
700+
if (%unsatisfied && $self->{PREREQ_FATAL}){
701+
my $failedprereqs = join "\n", map {" $_ $unsatisfied{$_}"}
702+
sort { $a cmp $b } keys %unsatisfied;
703+
die <<"END";
704+
MakeMaker FATAL: prerequisites not found.
705+
$failedprereqs
706+
707+
Please install these modules first and rerun 'perl Makefile.PL'.
708+
END
709+
}
716710
}
717711

718712
sub check_min_perl_version {

0 commit comments

Comments
 (0)