Skip to content

Commit e0bcb6e

Browse files
committed
Breakup MakeMaker->new: check_PREREQ_FATAL method
1 parent c622331 commit e0bcb6e

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

lib/ExtUtils/MakeMaker.pm

+16-11
Original file line numberDiff line numberDiff line change
@@ -445,17 +445,7 @@ sub new {
445445

446446
$self->extract_ARGV(\@ARGV);
447447

448-
# RT#91540 PREREQ_FATAL not recognized on command line
449-
if (%$unsatisfied_prereqs && $self->{PREREQ_FATAL}){
450-
my $failedprereqs = join "\n", map {" $_ $unsatisfied_prereqs->{$_}"}
451-
sort { $a cmp $b } keys %$unsatisfied_prereqs;
452-
die <<"END";
453-
MakeMaker FATAL: prerequisites not found.
454-
$failedprereqs
455-
456-
Please install these modules first and rerun 'perl Makefile.PL'.
457-
END
458-
}
448+
$self->check_PREREQ_FATAL($unsatisfied_prereqs); # after ARGV processed
459449

460450
$self->{NAME} ||= $self->guess_name;
461451
warn "Warning: NAME must be a package name\n"
@@ -475,6 +465,21 @@ END
475465
$self;
476466
}
477467

468+
sub check_PREREQ_FATAL {
469+
my ($self, $unsatisfied_prereqs) = @_;
470+
# RT#91540 PREREQ_FATAL not recognized on command line
471+
if (%$unsatisfied_prereqs && $self->{PREREQ_FATAL}){
472+
my $failedprereqs = join "\n", map {" $_ $unsatisfied_prereqs->{$_}"}
473+
sort { $a cmp $b } keys %$unsatisfied_prereqs;
474+
die <<"END";
475+
MakeMaker FATAL: prerequisites not found.
476+
$failedprereqs
477+
478+
Please install these modules first and rerun 'perl Makefile.PL'.
479+
END
480+
}
481+
}
482+
478483
sub extract_CONFIGURE {
479484
my ($self) = @_;
480485
my %initial_att = %$self; # record initial attributes

0 commit comments

Comments
 (0)