Skip to content

Commit b05c0e4

Browse files
drashnamechmerlin
drashna
authored and
mechmerlin
committed
Adds a default value for IS_COMMAND for COMMAND feature (qmk#4301)
* Add default value for IS_COMMAND for COMMAND feature * Cleanup and consistency * Update Templates to reflect change * Fix IS_COMMAND in template * Fix IS_COMMAND define * Use consistent IS_COMMAND block in templates * Remove unnecessary `#undef IS_COMMAND` directives * Fix compile issue on orthodox * Reomve IS_COMMAND option for newer boards * Remove all existing definitions of IS_COMMAND if they use default LSHIFT and RSHIFT setting * Remove a couple of additional IS_COMMAND defines * Remove remaining redundant IS_COMMAND definitions * Remove #undef IS_COMMAND from orthodox:drashna and whitefox:konstantin * Remove multiple empty lines in modified config.h files * Update additional boards * Reomve IS_COMMAND from newer boards * Update Alice keyboard * Remove IS_COMMAND from additional boards Jan 24th edition
1 parent 478538e commit b05c0e4

File tree

362 files changed

+47
-1960
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

362 files changed

+47
-1960
lines changed

‎keyboards/1upkeyboards/1up60hse/config.h

-6
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
112112
*
113113
*/
114114

115-
/* key combination for magic key command */
116-
#define IS_COMMAND() ( \
117-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
118-
)
119-
120115
/* control how magic key switches layers */
121116
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
122117
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true
@@ -221,4 +216,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
221216
#define LCD_E_PIN 1 //< pin for Enable line
222217
#endif
223218
*/
224-

‎keyboards/1upkeyboards/1up60rgb/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@
3838
/* Locking resynchronize hack */
3939
#define LOCKING_RESYNC_ENABLE
4040

41-
/* key combination for command */
42-
#define IS_COMMAND() ( \
43-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
44-
)
45-
4641
#define RGB_DI_PIN E2
4742
#ifdef RGB_DI_PIN
4843
#define RGBLIGHT_ANIMATIONS

‎keyboards/1upkeyboards/sweet16/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@
3838
/* Locking resynchronize hack */
3939
#define LOCKING_RESYNC_ENABLE
4040

41-
/* key combination for command */
42-
#define IS_COMMAND() ( \
43-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
44-
)
45-
4641
#define RGB_DI_PIN B1
4742
#ifdef RGB_DI_PIN
4843
#define RGBLIGHT_ANIMATIONS

‎keyboards/30wer/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,5 @@
2222
/* COL2ROW or ROW2COL */
2323
#define DIODE_DIRECTION COL2ROW
2424

25-
/* key combination for command */
26-
#define IS_COMMAND() ( \
27-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
28-
)
29-
3025
/* prevent stuck modifiers */
3126
#define PREVENT_STUCK_MODIFIERS

‎keyboards/40percentclub/25/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,6 @@
121121
*
122122
*/
123123

124-
/* key combination for magic key command */
125-
#define IS_COMMAND() ( \
126-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
127-
)
128-
129124
/* control how magic key switches layers */
130125
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
131126
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/4x4/config.h

-8
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,13 @@
3030
#define MATRIX_COL_PINS { C6, D7, E6, B4, B5, B6, B7, D6, F7, F6, F5, F4, F1, F0, B3, B1 }
3131
#define UNUSED_PINS
3232

33-
3433
/* COL2ROW, ROW2COL, or CUSTOM_MATRIX */
3534
#define DIODE_DIRECTION COL2ROW
3635

3736
// #define BACKLIGHT_PIN C7
3837
// #define BACKLIGHT_BREATHING
3938
// #define BACKLIGHT_LEVELS 3
4039

41-
4240
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
4341
#define DEBOUNCING_DELAY 5
4442

@@ -90,11 +88,6 @@
9088
*
9189
*/
9290

93-
/* key combination for magic key command */
94-
#define IS_COMMAND() ( \
95-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
96-
)
97-
9891
/* control how magic key switches layers */
9992
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
10093
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true
@@ -199,4 +192,3 @@
199192
#define LCD_E_PIN 1 //< pin for Enable line
200193
#endif
201194
*/
202-

‎keyboards/40percentclub/5x5/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,6 @@
9797
*
9898
*/
9999

100-
/* key combination for magic key command */
101-
#define IS_COMMAND() ( \
102-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
103-
)
104-
105100
/* control how magic key switches layers */
106101
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
107102
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/6lit/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,6 @@
122122
*
123123
*/
124124

125-
/* key combination for magic key command */
126-
#define IS_COMMAND() ( \
127-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
128-
)
129-
130125
/* control how magic key switches layers */
131126
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
132127
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/foobar/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,6 @@
122122
*
123123
*/
124124

125-
/* key combination for magic key command */
126-
#define IS_COMMAND() ( \
127-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
128-
)
129-
130125
/* control how magic key switches layers */
131126
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
132127
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/gherkin/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@
3737
/* Locking resynchronize hack */
3838
#define LOCKING_RESYNC_ENABLE
3939

40-
/* key combination for command */
41-
#define IS_COMMAND() ( \
42-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
43-
)
44-
4540
#ifdef RGB_DI_PIN
4641
#define RGBLIGHT_ANIMATIONS
4742
#define RGBLED_NUM 0

‎keyboards/40percentclub/i75/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@
7777
*
7878
*/
7979

80-
/* key combination for magic key command */
81-
#define IS_COMMAND() ( \
82-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
83-
)
84-
8580
/* control how magic key switches layers */
8681
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
8782
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/luddite/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@
3434
/* Locking resynchronize hack */
3535
#define LOCKING_RESYNC_ENABLE
3636

37-
/* key combination for command */
38-
#define IS_COMMAND() ( \
39-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
40-
)
41-
4237
/* ws2812 RGB LED */
4338
#define RGB_DI_PIN B4
4439
#define RGBLIGHT_ANIMATIONS

‎keyboards/40percentclub/mf68/config.h

-6
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
5252
#define BACKLIGHT_BREATHING
5353
#define BACKLIGHT_LEVELS 3
5454

55-
5655
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
5756
#define DEBOUNCING_DELAY 5
5857

@@ -99,11 +98,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
9998
*
10099
*/
101100

102-
/* key combination for magic key command */
103-
#define IS_COMMAND() ( \
104-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
105-
)
106-
107101
/* control how magic key switches layers */
108102
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
109103
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/mf68_ble/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
9999
*
100100
*/
101101

102-
/* key combination for magic key command */
103-
#define IS_COMMAND() ( \
104-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
105-
)
106-
107102
/* control how magic key switches layers */
108103
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
109104
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/nori/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,6 @@
110110
*
111111
*/
112112

113-
/* key combination for magic key command */
114-
#define IS_COMMAND() ( \
115-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
116-
)
117-
118113
/* control how magic key switches layers */
119114
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
120115
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/40percentclub/tomato/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@
2828
/* Locking resynchronize hack */
2929
#define LOCKING_RESYNC_ENABLE
3030

31-
/* key combination for command */
32-
#define IS_COMMAND() ( \
33-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
34-
)
35-
3631
/* eliminate lag on space cadet mods */
3732
#define PERMISSIVE_HOLD
3833

‎keyboards/40percentclub/ut47/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
5353
/* Locking resynchronize hack */
5454
#define LOCKING_RESYNC_ENABLE
5555

56-
/* key combination for magic key command */
57-
#define IS_COMMAND() ( \
58-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
59-
)
60-
6156
/* Enable GNAP matrix serial output */
6257
#define GNAP_ENABLE
6358

‎keyboards/412_64/config.h

-8
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,13 @@
3030
#define MATRIX_COL_PINS { B0, D2, D0, D1, D4, C6, D7, E6 }
3131
#define UNUSED_PINS { B4, B5, B6, B7, C7, F0, F1 }
3232

33-
3433
/* COL2ROW, ROW2COL, or CUSTOM_MATRIX */
3534
#define DIODE_DIRECTION COL2ROW
3635

3736
// #define BACKLIGHT_PIN C7
3837
// #define BACKLIGHT_BREATHING
3938
// #define BACKLIGHT_LEVELS 3
4039

41-
4240
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
4341
#define DEBOUNCING_DELAY 5
4442

@@ -90,11 +88,6 @@
9088
*
9189
*/
9290

93-
/* key combination for magic key command */
94-
#define IS_COMMAND() ( \
95-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
96-
)
97-
9891
/* control how magic key switches layers */
9992
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
10093
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true
@@ -199,4 +192,3 @@
199192
#define LCD_E_PIN 1 //< pin for Enable line
200193
#endif
201194
*/
202-

‎keyboards/acr60/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@
3636
/* Locking resynchronize hack */
3737
#define LOCKING_RESYNC_ENABLE
3838

39-
/* key combination for command */
40-
#define IS_COMMAND() ( \
41-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
42-
)
43-
4439
#define RGB_DI_PIN E2
4540
#define RGBLIGHT_ANIMATIONS
4641
#define RGBLED_NUM 20

‎keyboards/al1/config.h

-6
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
5050
#define BACKLIGHT_BREATHING
5151
#define BACKLIGHT_LEVELS 3
5252

53-
5453
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
5554
#define DEBOUNCING_DELAY 5
5655

@@ -102,11 +101,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
102101
*
103102
*/
104103

105-
/* key combination for magic key command */
106-
#define IS_COMMAND() ( \
107-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
108-
)
109-
110104
/* control how magic key switches layers */
111105
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
112106
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true

‎keyboards/alf/dc60/config.h

-6
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
112112
*
113113
*/
114114

115-
/* key combination for magic key command */
116-
#define IS_COMMAND() ( \
117-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
118-
)
119-
120115
/* control how magic key switches layers */
121116
//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
122117
//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true
@@ -221,4 +216,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
221216
#define LCD_E_PIN 1 //< pin for Enable line
222217
#endif
223218
*/
224-

‎keyboards/alf/x2/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@
3838
/* Locking resynchronize hack */
3939
#define LOCKING_RESYNC_ENABLE
4040

41-
/* key combination for command */
42-
#define IS_COMMAND() ( \
43-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
44-
)
45-
4641
#define RGB_DI_PIN E2
4742
#ifdef RGB_DI_PIN
4843
#define RGBLIGHT_ANIMATIONS

‎keyboards/alice/config.h

-3
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
3737

3838
#define NO_UART 1
3939
#define BOOTLOADHID_BOOTLOADER 1
40-
41-
/* key combination for command */
42-
#define IS_COMMAND() (keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)))

‎keyboards/alpha/config.h

-6
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@
3838
/* Locking resynchronize hack */
3939
#define LOCKING_RESYNC_ENABLE
4040

41-
/* key combination for command */
42-
#define IS_COMMAND() ( \
43-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
44-
)
45-
46-
4741
#define RGB_DI_PIN F4
4842
#ifdef RGB_DI_PIN
4943
#define RGBLIGHT_ANIMATIONS

‎keyboards/alps64/config.h

-7
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
4747
/* Locking resynchronize hack */
4848
#define LOCKING_RESYNC_ENABLE
4949

50-
/* key combination for command */
51-
#define IS_COMMAND() ( \
52-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
53-
)
54-
55-
56-
5750
/*
5851
* Feature disable options
5952
* These options are also useful to firmware size reduction.

‎keyboards/alu84/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,6 @@
5454
/* Locking resynchronize hack */
5555
#define LOCKING_RESYNC_ENABLE
5656

57-
/* key combination for command */
58-
#define IS_COMMAND() ( \
59-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
60-
)
61-
6257
#define RGB_DI_PIN E2
6358
#ifdef RGB_DI_PIN
6459
#define RGBLED_NUM 16

‎keyboards/amj40/config.h

-5
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
5454
/* Locking resynchronize hack */
5555
#define LOCKING_RESYNC_ENABLE
5656

57-
/* key combination for command */
58-
#define IS_COMMAND() ( \
59-
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
60-
)
61-
6257
/* Backlight configuration
6358
*/
6459
#define BACKLIGHT_LEVELS 4

0 commit comments

Comments
 (0)