use emplace_back and reserve for some vectors (#1724)

Coronia · web-flow · commit e18cdc093085 · 2025-06-16T17:27:57.000+08:00
diff --git a/src/Ext/Building/Body.cpp b/src/Ext/Building/Body.cpp
@@ -427,7 +427,7 @@ const std::vector<CellStruct> BuildingExt::GetFoundationCells(BuildingClass* con
 
 		for (auto i = occupyHeight; i > 0; --i)
 		{
-			foundationCells.push_back(actualCell);
+			foundationCells.emplace_back(actualCell);
 			--actualCell.X;
 			--actualCell.Y;
 		}
diff --git a/src/Ext/Bullet/Trajectories/PhobosTrajectory.cpp b/src/Ext/Bullet/Trajectories/PhobosTrajectory.cpp
@@ -205,7 +205,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 	std::vector<CellStruct> recCells;
 	const auto cellNums = (std::abs(topEndCell.Y - bottomStaCell.Y) + 1) * (std::abs(rightMidCell.X - leftMidCell.X) + 1);
 	recCells.reserve(cellNums);
-	recCells.push_back(bottomStaCell);
+	recCells.emplace_back(bottomStaCell);
 
 	if (bottomStaCell == leftMidCell || bottomStaCell == rightMidCell) // A straight line
 	{
@@ -222,24 +222,24 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 			{
 				mTheCurN -= middleThePace.X;
 				middleCurCell.Y += middleTheUnit.Y;
-				recCells.push_back(middleCurCell);
+				recCells.emplace_back(middleCurCell);
 			}
 			else if (mTheCurN < 0)
 			{
 				mTheCurN += middleThePace.Y;
 				middleCurCell.X += middleTheUnit.X;
-				recCells.push_back(middleCurCell);
+				recCells.emplace_back(middleCurCell);
 			}
 			else
 			{
 				mTheCurN += middleThePace.Y - middleThePace.X;
 				middleCurCell.X += middleTheUnit.X;
-				recCells.push_back(middleCurCell);
+				recCells.emplace_back(middleCurCell);
 				middleCurCell.X -= middleTheUnit.X;
 				middleCurCell.Y += middleTheUnit.Y;
-				recCells.push_back(middleCurCell);
+				recCells.emplace_back(middleCurCell);
 				middleCurCell.X += middleTheUnit.X;
-				recCells.push_back(middleCurCell);
+				recCells.emplace_back(middleCurCell);
 			}
 		}
 	}
@@ -293,7 +293,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 						}
 						else
 						{
-							recCells.push_back(leftCurCell);
+							recCells.emplace_back(leftCurCell);
 							break;
 						}
 					}
@@ -333,7 +333,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 				}
 
 				if (leftCurCell != rightCurCell) // Avoid double counting cells.
-					recCells.push_back(leftCurCell);
+					recCells.emplace_back(leftCurCell);
 			}
 
 			while (rightCurCell != topEndCell) // Right
@@ -351,7 +351,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 						}
 						else
 						{
-							recCells.push_back(rightCurCell);
+							recCells.emplace_back(rightCurCell);
 							break;
 						}
 					}
@@ -391,15 +391,15 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 				}
 
 				if (rightCurCell != leftCurCell) // Avoid double counting cells.
-					recCells.push_back(rightCurCell);
+					recCells.emplace_back(rightCurCell);
 			}
 
 			middleCurCell = leftCurCell;
 			middleCurCell.X += 1;
 
 			while (middleCurCell.X < rightCurCell.X) // Center
 			{
-				recCells.push_back(middleCurCell);
+				recCells.emplace_back(middleCurCell);
 				middleCurCell.X += 1;
 			}
 
@@ -408,15 +408,15 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot
 				leftContinue = false;
 				left2ndCurN -= left2ndPace.X;
 				leftCurCell.Y += left2ndUnit.Y;
-				recCells.push_back(leftCurCell);
+				recCells.emplace_back(leftCurCell);
 			}
 
 			if (rightContinue) // Continue Top Right Side
 			{
 				rightContinue = false;
 				right2ndCurN -= right2ndPace.X;
 				rightCurCell.Y += right2ndUnit.Y;
-				recCells.push_back(rightCurCell);
+				recCells.emplace_back(rightCurCell);
 			}
 		}
 	}
diff --git a/src/Ext/Bullet/Trajectories/StraightTrajectory.cpp b/src/Ext/Bullet/Trajectories/StraightTrajectory.cpp
@@ -909,6 +909,7 @@ void StraightTrajectory::PrepareForDetonateAt(BulletClass* pBullet, HouseClass*
 		this->TheCasualty.erase(ID);
 
 	std::vector<TechnoClass*> validTargets;
+	validTargets.reserve(validTechnos.size());
 
 	// checking for duplicate
 	for (const auto& pTechno : validTechnos)
diff --git a/src/Ext/House/Body.cpp b/src/Ext/House/Body.cpp
@@ -35,7 +35,9 @@ void HouseExt::ExtData::UpdateVehicleProduction()
 	auto& bestChoicesNaval = HouseExt::AIProduction_BestChoicesNaval;
 
 	auto const count = static_cast<unsigned int>(UnitTypeClass::Array.Count);
+	creationFrames.reserve(count);
 	creationFrames.assign(count, 0x7FFFFFFF);
+	values.reserve(count);
 	values.assign(count, 0);
 
 	for (auto currentTeam : TeamClass::Array)
diff --git a/src/Ext/Rules/Body.cpp b/src/Ext/Rules/Body.cpp
@@ -276,7 +276,7 @@ void RulesExt::ExtData::LoadBeforeTypeData(RulesClass* pThis, CCINIClass* pINI)
 	this->AnimCraterDestroyTiberium.Read(exINI, GameStrings::General, "AnimCraterDestroyTiberium");
 
 	this->BerzerkTargeting.Read(exINI, GameStrings::CombatDamage, "BerzerkTargeting");
-	
+
 	// Section AITargetTypes
 	int itemsCount = pINI->GetKeyCount("AITargetTypes");
 	for (int i = 0; i < itemsCount; ++i)
diff --git a/src/Ext/Rules/Body.h b/src/Ext/Rules/Body.h
@@ -234,7 +234,7 @@ class RulesExt
 		int TintColorIronCurtain;
 		int TintColorForceShield;
 		int TintColorBerserk;
-		
+
 		ExtData(RulesClass* OwnerObject) : Extension<RulesClass>(OwnerObject)
 			, Storage_TiberiumIndex { -1 }
 			, HarvesterDumpAmount { 0.0f }
@@ -408,7 +408,7 @@ class RulesExt
 			, HarvesterScanAfterUnload { false }
 
 			, AnimCraterDestroyTiberium { true }
-			
+
 			, BerzerkTargeting { AffectedHouse::All }
 
 			, TintColorIronCurtain { 0 }
diff --git a/src/Ext/SWType/Body.cpp b/src/Ext/SWType/Body.cpp
@@ -170,7 +170,7 @@ void SWTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI)
 		if (this->LimboDelivery_RandomWeightsData.size() > i)
 			this->LimboDelivery_RandomWeightsData[i] = std::move(weights);
 		else
-			this->LimboDelivery_RandomWeightsData.push_back(std::move(weights));
+			this->LimboDelivery_RandomWeightsData.emplace_back(std::move(weights));
 	}
 
 	ValueableVector<int> weights;
@@ -180,7 +180,7 @@ void SWTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI)
 		if (this->LimboDelivery_RandomWeightsData.size())
 			this->LimboDelivery_RandomWeightsData[0] = std::move(weights);
 		else
-			this->LimboDelivery_RandomWeightsData.push_back(std::move(weights));
+			this->LimboDelivery_RandomWeightsData.emplace_back(std::move(weights));
 	}
 
 	// SW.Next.RandomWeights
@@ -196,7 +196,7 @@ void SWTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI)
 		if (this->SW_Next_RandomWeightsData.size() > i)
 			this->SW_Next_RandomWeightsData[i] = std::move(weights2);
 		else
-			this->SW_Next_RandomWeightsData.push_back(std::move(weights2));
+			this->SW_Next_RandomWeightsData.emplace_back(std::move(weights2));
 	}
 
 	ValueableVector<int> weights2;
@@ -206,7 +206,7 @@ void SWTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI)
 		if (this->SW_Next_RandomWeightsData.size())
 			this->SW_Next_RandomWeightsData[0] = std::move(weights2);
 		else
-			this->SW_Next_RandomWeightsData.push_back(std::move(weights2));
+			this->SW_Next_RandomWeightsData.emplace_back(std::move(weights2));
 	}
 
 	this->Detonate_Warhead.Read<true>(exINI, pSection, "Detonate.Warhead");
diff --git a/src/Ext/SWType/SWHelpers.cpp b/src/Ext/SWType/SWHelpers.cpp
@@ -17,6 +17,8 @@ std::vector<int> SWTypeExt::ExtData::WeightedRollsHandler(ValueableVector<float>
 		rollOnce = true;
 	}
 
+	indices.reserve(rollsSize);
+
 	for (size_t i = 0; i < rollsSize; i++)
 	{
 		this->RandomBuffer = ScenarioClass::Instance->Random.RandomDouble();
@@ -32,6 +34,7 @@ std::vector<int> SWTypeExt::ExtData::WeightedRollsHandler(ValueableVector<float>
 		if (size_t(index) < size)
 			indices.push_back(index);
 	}
+
 	return indices;
 }
 
diff --git a/src/Ext/Script/Mission.Attack.cpp b/src/Ext/Script/Mission.Attack.cpp
@@ -1379,6 +1379,7 @@ void ScriptExt::Mission_Attack_List1Random(TeamClass* pTeam, int calcThreatMode,
 		if (idxSelectedObject < 0 && objectsList.size() > 0 && !selected)
 		{
 			const auto pFirstUnit = pTeam->FirstUnit;
+			validIndexes.reserve(TechnoClass::Array.Count * objectsList.size());
 
 			// Finding the objects from the list that actually exists in the map
 			for (int i = 0; i < TechnoClass::Array.Count; i++)
diff --git a/src/Ext/Script/Mission.Move.cpp b/src/Ext/Script/Mission.Move.cpp
@@ -436,6 +436,7 @@ void ScriptExt::Mission_Move_List1Random(TeamClass* pTeam, int calcThreatMode, b
 		if (idxSelectedObject < 0 && objectsList.size() > 0 && !selected)
 		{
 			const auto pFirstUnit = pTeam->FirstUnit;
+			validIndexes.reserve(TechnoClass::Array.Count * objectsList.size());
 
 			// Finding the objects from the list that actually exists in the map
 			for (int i = 0; i < TechnoClass::Array.Count; i++)
diff --git a/src/Ext/Sidebar/SWSidebar/SWSidebarClass.cpp b/src/Ext/Sidebar/SWSidebar/SWSidebarClass.cpp
@@ -264,6 +264,7 @@ void SWSidebarClass::RecheckCameo()
 	for (const auto& column : sidebar.Columns)
 	{
 		std::vector<int> removeButtons;
+		removeButtons.reserve(column->Buttons.size());
 
 		for (const auto& button : column->Buttons)
 		{
diff --git a/src/Ext/TAction/Body.cpp b/src/Ext/TAction/Body.cpp
@@ -309,6 +309,8 @@ bool TActionExt::RunSuperWeaponAt(TActionClass* pThis, int X, int Y)
 		switch (pThis->Param4)
 		{
 		case -1:
+			housesList.reserve(HouseClass::Array.Count);
+
 			// Random non-neutral
 			for (auto pHouse : HouseClass::Array)
 			{
@@ -341,6 +343,8 @@ bool TActionExt::RunSuperWeaponAt(TActionClass* pThis, int X, int Y)
 			break;
 
 		case -3:
+			housesList.reserve(HouseClass::Array.Count);
+
 			// Random Human Player
 			for (auto pHouse : HouseClass::Array)
 			{
diff --git a/src/Ext/TechnoType/Body.cpp b/src/Ext/TechnoType/Body.cpp
@@ -145,8 +145,8 @@ void TechnoTypeExt::ExtData::ParseBurstFLHs(INI_EX& exArtINI, const char* pArtSe
 			else if (!FLH.isset() && !eliteFLH.isset())
 				break;
 
-			nFLH[i].push_back(FLH.Get());
-			nEFlh[i].push_back(eliteFLH.Get());
+			nFLH[i].emplace_back(FLH.Get());
+			nEFlh[i].emplace_back(eliteFLH.Get());
 		}
 	}
 }
@@ -869,7 +869,7 @@ void TechnoTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI)
 		if (this->AlternateFLHs.size() < i)
 			this->AlternateFLHs[i] = alternateFLH;
 		else
-			this->AlternateFLHs.push_back(alternateFLH);
+			this->AlternateFLHs.emplace_back(alternateFLH);
 	}
 
 	// Parasitic types
diff --git a/src/Misc/FlyingStrings.cpp b/src/Misc/FlyingStrings.cpp
@@ -27,7 +27,7 @@ void FlyingStrings::Add(const wchar_t* text, const CoordStruct& coords, ColorStr
 	item.CreationFrame = Unsorted::CurrentFrame;
 	item.Color = Drawing::RGB_To_Int(color);
 	PhobosCRT::wstrCopy(item.Text, text, 0x20);
-	Data.push_back(item);
+	Data.emplace_back(item);
 }
 
 void FlyingStrings::AddMoneyString(int amount, HouseClass* owner, AffectedHouse displayToHouses, const CoordStruct& coords, Point2D pixelOffset)
diff --git a/src/New/Entity/AttachEffectClass.cpp b/src/New/Entity/AttachEffectClass.cpp
@@ -658,6 +658,7 @@ AttachEffectClass* AttachEffectClass::CreateAndAttach(AttachEffectTypeClass* pTy
 	int currentTypeCount = 0;
 	AttachEffectClass* match = nullptr;
 	std::vector<AttachEffectClass*> cumulativeMatches;
+	cumulativeMatches.reserve(targetAEs.size());
 
 	for (auto const& aePtr : targetAEs)
 	{
@@ -757,6 +758,7 @@ int AttachEffectClass::DetachByGroups(TechnoClass* pTarget, AEAttachInfoTypeClas
 
 	auto const pTargetExt = TechnoExt::ExtMap.Find(pTarget);
 	std::vector<AttachEffectTypeClass*> types;
+	types.reserve(pTargetExt->AttachedEffects.size());
 
 	for (auto const& attachEffect : pTargetExt->AttachedEffects)
 	{
diff --git a/src/Utilities/GeneralUtils.cpp b/src/Utilities/GeneralUtils.cpp
@@ -51,6 +51,7 @@ const wchar_t* GeneralUtils::LoadStringUnlessMissing(const char* key, const wcha
 std::vector<CellStruct> GeneralUtils::AdjacentCellsInRange(unsigned int range)
 {
 	std::vector<CellStruct> result;
+	result.reserve((2 * range + 1) * (2 * range + 1));
 
 	for (CellSpreadEnumerator it(range); it; ++it)
 		result.push_back(*it);
@@ -167,6 +168,7 @@ bool GeneralUtils::ApplyTheaterSuffixToString(char* str)
 std::string GeneralUtils::IntToDigits(int num)
 {
 	std::string digits;
+	digits.reserve(10); // 32-bit int max: 2,147,483,647 (10 digits)
 
 	if (num == 0)
 	{
diff --git a/src/Utilities/ShapeTextPrinter.cpp b/src/Utilities/ShapeTextPrinter.cpp
@@ -15,6 +15,7 @@ void ShapeTextPrinter::PrintShape
 {
 	const int length = strlen(text);
 	std::vector<int> frames;
+	frames.reserve(length);
 
 	for (int i = 0; i < length; i++)
 	{

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ const std::vector<CellStruct> BuildingExt::GetFoundationCells(BuildingClass* con`
`427`	`427`
`428`	`428`	`for (auto i = occupyHeight; i > 0; --i)`
`429`	`429`	`{`
`430`		`- foundationCells.push_back(actualCell);`
	`430`	`+ foundationCells.emplace_back(actualCell);`
`431`	`431`	`--actualCell.X;`
`432`	`432`	`--actualCell.Y;`
`433`	`433`	`}`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`205`	`205`	`std::vector<CellStruct> recCells;`
`206`	`206`	`const auto cellNums = (std::abs(topEndCell.Y - bottomStaCell.Y) + 1) * (std::abs(rightMidCell.X - leftMidCell.X) + 1);`
`207`	`207`	`recCells.reserve(cellNums);`
`208`		`- recCells.push_back(bottomStaCell);`
	`208`	`+ recCells.emplace_back(bottomStaCell);`
`209`	`209`
`210`	`210`	`if (bottomStaCell == leftMidCell \|\| bottomStaCell == rightMidCell) // A straight line`
`211`	`211`	`{`
`@@ -222,24 +222,24 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`222`	`222`	`{`
`223`	`223`	`mTheCurN -= middleThePace.X;`
`224`	`224`	`middleCurCell.Y += middleTheUnit.Y;`
`225`		`- recCells.push_back(middleCurCell);`
	`225`	`+ recCells.emplace_back(middleCurCell);`
`226`	`226`	`}`
`227`	`227`	`else if (mTheCurN < 0)`
`228`	`228`	`{`
`229`	`229`	`mTheCurN += middleThePace.Y;`
`230`	`230`	`middleCurCell.X += middleTheUnit.X;`
`231`		`- recCells.push_back(middleCurCell);`
	`231`	`+ recCells.emplace_back(middleCurCell);`
`232`	`232`	`}`
`233`	`233`	`else`
`234`	`234`	`{`
`235`	`235`	`mTheCurN += middleThePace.Y - middleThePace.X;`
`236`	`236`	`middleCurCell.X += middleTheUnit.X;`
`237`		`- recCells.push_back(middleCurCell);`
	`237`	`+ recCells.emplace_back(middleCurCell);`
`238`	`238`	`middleCurCell.X -= middleTheUnit.X;`
`239`	`239`	`middleCurCell.Y += middleTheUnit.Y;`
`240`		`- recCells.push_back(middleCurCell);`
	`240`	`+ recCells.emplace_back(middleCurCell);`
`241`	`241`	`middleCurCell.X += middleTheUnit.X;`
`242`		`- recCells.push_back(middleCurCell);`
	`242`	`+ recCells.emplace_back(middleCurCell);`
`243`	`243`	`}`
`244`	`244`	`}`
`245`	`245`	`}`
`@@ -293,7 +293,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`293`	`293`	`}`
`294`	`294`	`else`
`295`	`295`	`{`
`296`		`- recCells.push_back(leftCurCell);`
	`296`	`+ recCells.emplace_back(leftCurCell);`
`297`	`297`	`break;`
`298`	`298`	`}`
`299`	`299`	`}`
`@@ -333,7 +333,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`if (leftCurCell != rightCurCell) // Avoid double counting cells.`
`336`		`- recCells.push_back(leftCurCell);`
	`336`	`+ recCells.emplace_back(leftCurCell);`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`while (rightCurCell != topEndCell) // Right`
`@@ -351,7 +351,7 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`351`	`351`	`}`
`352`	`352`	`else`
`353`	`353`	`{`
`354`		`- recCells.push_back(rightCurCell);`
	`354`	`+ recCells.emplace_back(rightCurCell);`
`355`	`355`	`break;`
`356`	`356`	`}`
`357`	`357`	`}`
`@@ -391,15 +391,15 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`391`	`391`	`}`
`392`	`392`
`393`	`393`	`if (rightCurCell != leftCurCell) // Avoid double counting cells.`
`394`		`- recCells.push_back(rightCurCell);`
	`394`	`+ recCells.emplace_back(rightCurCell);`
`395`	`395`	`}`
`396`	`396`
`397`	`397`	`middleCurCell = leftCurCell;`
`398`	`398`	`middleCurCell.X += 1;`
`399`	`399`
`400`	`400`	`while (middleCurCell.X < rightCurCell.X) // Center`
`401`	`401`	`{`
`402`		`- recCells.push_back(middleCurCell);`
	`402`	`+ recCells.emplace_back(middleCurCell);`
`403`	`403`	`middleCurCell.X += 1;`
`404`	`404`	`}`
`405`	`405`
`@@ -408,15 +408,15 @@ std::vector<CellStruct> PhobosTrajectoryType::GetCellsInRectangle(CellStruct bot`
`408`	`408`	`leftContinue = false;`
`409`	`409`	`left2ndCurN -= left2ndPace.X;`
`410`	`410`	`leftCurCell.Y += left2ndUnit.Y;`
`411`		`- recCells.push_back(leftCurCell);`
	`411`	`+ recCells.emplace_back(leftCurCell);`
`412`	`412`	`}`
`413`	`413`
`414`	`414`	`if (rightContinue) // Continue Top Right Side`
`415`	`415`	`{`
`416`	`416`	`rightContinue = false;`
`417`	`417`	`right2ndCurN -= right2ndPace.X;`
`418`	`418`	`rightCurCell.Y += right2ndUnit.Y;`
`419`		`- recCells.push_back(rightCurCell);`
	`419`	`+ recCells.emplace_back(rightCurCell);`
`420`	`420`	`}`
`421`	`421`	`}`
`422`	`422`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@ std::vector<int> SWTypeExt::ExtData::WeightedRollsHandler(ValueableVector<float>`
`17`	`17`	`rollOnce = true;`
`18`	`18`	`}`
`19`	`19`
	`20`	`+ indices.reserve(rollsSize);`
	`21`	`+`
`20`	`22`	`for (size_t i = 0; i < rollsSize; i++)`
`21`	`23`	`{`
`22`	`24`	`this->RandomBuffer = ScenarioClass::Instance->Random.RandomDouble();`
`@@ -32,6 +34,7 @@ std::vector<int> SWTypeExt::ExtData::WeightedRollsHandler(ValueableVector<float>`
`32`	`34`	`if (size_t(index) < size)`
`33`	`35`	`indices.push_back(index);`
`34`	`36`	`}`
	`37`	`+`
`35`	`38`	`return indices;`
`36`	`39`	`}`
`37`	`40`
Original file line number	Diff line number	Diff line change
`@@ -1379,6 +1379,7 @@ void ScriptExt::Mission_Attack_List1Random(TeamClass* pTeam, int calcThreatMode,`
`1379`	`1379`	`if (idxSelectedObject < 0 && objectsList.size() > 0 && !selected)`
`1380`	`1380`	`{`
`1381`	`1381`	`const auto pFirstUnit = pTeam->FirstUnit;`
	`1382`	`+ validIndexes.reserve(TechnoClass::Array.Count * objectsList.size());`
`1382`	`1383`
`1383`	`1384`	`// Finding the objects from the list that actually exists in the map`
`1384`	`1385`	`for (int i = 0; i < TechnoClass::Array.Count; i++)`
Original file line number	Diff line number	Diff line change
`@@ -436,6 +436,7 @@ void ScriptExt::Mission_Move_List1Random(TeamClass* pTeam, int calcThreatMode, b`
`436`	`436`	`if (idxSelectedObject < 0 && objectsList.size() > 0 && !selected)`
`437`	`437`	`{`
`438`	`438`	`const auto pFirstUnit = pTeam->FirstUnit;`
	`439`	`+ validIndexes.reserve(TechnoClass::Array.Count * objectsList.size());`
`439`	`440`
`440`	`441`	`// Finding the objects from the list that actually exists in the map`
`441`	`442`	`for (int i = 0; i < TechnoClass::Array.Count; i++)`