fix BreakAnim

Author: Coronia

docs/New-or-Enhanced-Logics.md

@@ -470,7 +470,7 @@ CreateUnit.AlwaysSpawnOnGround=false   ; boolean
 CreateUnit.SpawnParachutedInAir=false  ; boolean
 CreateUnit.ConsiderPathfinding=false   ; boolean
 CreateUnit.SpawnAnim=                  ; list of Animation
-CreareUnit.SpawnHeight=                ; integer, height in leptons
+CreateUnit.SpawnHeight=                ; integer, height in leptons
 ```
 
 ```{note}

src/Ext/Techno/Body.Update.cpp

@@ -749,7 +749,7 @@ void TechnoExt::ExtData::ApplyMindControlRangeLimit()
 	}
 }
 
-void TechnoExt::KillSelf(TechnoClass* pThis, AutoDeathBehavior deathOption, std::vector<AnimTypeClass*> pVanishAnimation, bool isInLimbo)
+void TechnoExt::KillSelf(TechnoClass* pThis, AutoDeathBehavior deathOption, const std::vector<AnimTypeClass*>& pVanishAnimation, bool isInLimbo)
 {
 	if (isInLimbo)
 	{

src/Ext/Techno/Body.h

@@ -182,7 +182,7 @@ class TechnoExt
 	static CoordStruct GetSimpleFLH(InfantryClass* pThis, int weaponIndex, bool& FLHFound);
 
 	static void ChangeOwnerMissionFix(FootClass* pThis);
-	static void KillSelf(TechnoClass* pThis, AutoDeathBehavior deathOption, std::vector<AnimTypeClass*> pVanishAnimation, bool isInLimbo = false);
+	static void KillSelf(TechnoClass* pThis, AutoDeathBehavior deathOption, const std::vector<AnimTypeClass*>& pVanishAnimation, bool isInLimbo = false);
 	static void ObjectKilledBy(TechnoClass* pThis, TechnoClass* pKiller);
 	static void UpdateSharedAmmo(TechnoClass* pThis);
 	static double GetCurrentSpeedMultiplier(FootClass* pThis);

src/Ext/TechnoType/Body.cpp

@@ -113,7 +113,7 @@ TechnoTypeClass* TechnoTypeExt::GetTechnoType(ObjectTypeClass* pType)
 	return nullptr;
 }
 
-TechnoClass* TechnoTypeExt::CreateUnit(TechnoTypeClass* pType, CoordStruct location, DirType facing, DirType* secondaryFacing, HouseClass* pOwner, std::vector<AnimTypeClass*> pSpawnAnimType,
+TechnoClass* TechnoTypeExt::CreateUnit(TechnoTypeClass* pType, CoordStruct location, DirType facing, DirType* secondaryFacing, HouseClass* pOwner, const std::vector<AnimTypeClass*>& pSpawnAnimType,
 	TechnoClass* pInvoker, HouseClass* pInvokerHouse, int spawnHeight, bool alwaysOnGround, bool checkPathfinding, bool parachuteIfInAir, Mission mission, Mission* missionAI)
 {
 	auto const rtti = pType->WhatAmI();

src/Ext/TechnoType/Body.h

@@ -602,7 +602,7 @@ class TechnoTypeExt
 	static TechnoTypeClass* GetTechnoType(ObjectTypeClass* pType);
 
 	static TechnoClass* CreateUnit(TechnoTypeClass* pType, CoordStruct location, DirType facing, DirType* secondaryFacing, HouseClass* pOwner,
-		std::vector<AnimTypeClass*> pSpawnAnimType, TechnoClass* pInvoker = nullptr, HouseClass* pInvokerHouse = nullptr, int spawnHeight = -1,
+		const std::vector<AnimTypeClass*>& pSpawnAnimType, TechnoClass* pInvoker = nullptr, HouseClass* pInvokerHouse = nullptr, int spawnHeight = -1,
 		bool alwaysOnGround = false, bool checkPathfinding = false, bool parachuteIfInAir = false, Mission mission = Mission::Guard, Mission* missionAI = nullptr);
 
 	// Ares 0.A

src/New/Entity/ShieldClass.cpp

@@ -322,7 +322,7 @@ void ShieldClass::ResponseAttack()
 	}
 }
 
-void ShieldClass::WeaponNullifyAnim(std::vector<AnimTypeClass*> pHitAnim)
+void ShieldClass::WeaponNullifyAnim(std::vector<AnimTypeClass*>& pHitAnim)
 {
 	if (this->AreAnimsHidden)
 		return;
@@ -672,7 +672,7 @@ int ShieldClass::GetPercentageAmount(double iStatus)
 	return (int)std::trunc(iStatus);
 }
 
-void ShieldClass::BreakShield(std::vector<AnimTypeClass*> pBreakAnim, WeaponTypeClass* pBreakWeapon)
+void ShieldClass::BreakShield(std::vector<AnimTypeClass*>& pBreakAnim, WeaponTypeClass* pBreakWeapon)
 {
 	this->HP = 0;
 
@@ -684,7 +684,7 @@ void ShieldClass::BreakShield(std::vector<AnimTypeClass*> pBreakAnim, WeaponType
 
 	if (!this->AreAnimsHidden)
 	{
-		if (!pBreakAnim.empty())
+		if (pBreakAnim.empty())
 			pBreakAnim = this->Type->BreakAnim;
 
 		AnimExt::CreateRandomAnim(pBreakAnim, this->Techno->Location, this->Techno, nullptr, true, true);

src/New/Entity/ShieldClass.h

@@ -20,7 +20,7 @@ class ShieldClass
 	int ReceiveDamage(args_ReceiveDamage* args);
 	bool CanBeTargeted(WeaponTypeClass* pWeapon) const;
 	bool CanBePenetrated(WarheadTypeClass* pWarhead) const;
-	void BreakShield(std::vector<AnimTypeClass*> pBreakAnim, WeaponTypeClass* pBreakWeapon = nullptr);
+	void BreakShield(std::vector<AnimTypeClass*>& pBreakAnim, WeaponTypeClass* pBreakWeapon = nullptr);
 
 	void SetRespawn(int duration, double amount, int rate, bool resetTimer);
 	void SetSelfHealing(int duration, double amount, int rate, bool restartInCombat, int restartInCombatDelay, bool resetTimer);
@@ -92,7 +92,7 @@ class ShieldClass
 	void UpdateIdleAnim();
 	AnimTypeClass* GetIdleAnimType();
 
-	void WeaponNullifyAnim(std::vector<AnimTypeClass*> pHitAnim);
+	void WeaponNullifyAnim(std::vector<AnimTypeClass*>& pHitAnim);
 	void ResponseAttack();
 
 	void CloakCheck();