Breaking changes in EFCore 9 (was: PostgreSQL first run fails on pending model changes)

[RafaelGCPP]

Description:

Running PiranhaCMS with PostgreSQL fails immediatelly, during the Database.Migrate() called in the Db constructor.
While this seems a good idea, the behavior seems to differ depending on the database driver. In the SQLite version, the warning would not kill the driver, while in PostgreSQL it does!

EDIT: After some investigation, I finnaly figured out it is a breaking change in EF Core 9, that don't like .Migrate() being called when no extra migrations are available. I'll be digging deeper, so to help create a Db class compliant with the new guidelines.

Steps to reproduce

• dotnet new piranha.razor -o PU1OWL --database PostgreSql
• Edit appsettings.json to fix connection string.
• dotnet run --project PU1OWL\PU1OWL.csproj

Environment:

• Windows 11
• Microsoft Visual Studio Community 2022 Version 17.14.12
• EntityFramework Core 9.0.8
• PostgreSQL 17.6 running on a Docker container.

Complete exception log

System.InvalidOperationException

HResult=0x80131509

Message=An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'PostgreSqlDb' has pending changes. Add a new migration before updating the database. See https://aka.ms/efcore-docs-pending-changes. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Source=Microsoft.EntityFrameworkCore

StackTrace:

at Microsoft.EntityFrameworkCore.Diagnostics.EventDefinition1.Log[TLoggerCategory](IDiagnosticsLogger1 logger, TParam arg)

at Microsoft.EntityFrameworkCore.Diagnostics.RelationalLoggerExtensions.PendingModelChangesWarning(IDiagnosticsLogger1 diagnostics, Type contextType) at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.ValidateMigrations(Boolean useTransaction) at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration) at Npgsql.EntityFrameworkCore.PostgreSQL.Migrations.Internal.NpgsqlMigrator.Migrate(String targetMigration) at Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.Migrate(DatabaseFacade databaseFacade) at Piranha.Db1..ctor(DbContextOptions1 options) at Piranha.Data.EF.PostgreSql.PostgreSqlDb..ctor(DbContextOptions1 options)

at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite callSite, RuntimeResolverContext context) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(ServiceCallSite callSite, TArgument argument)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite callSite, RuntimeResolverContext context) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(ServiceCallSite callSite, TArgument argument)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite callSite, RuntimeResolverContext context) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(ServiceCallSite callSite, TArgument argument)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass2_0.b__0(ServiceProviderEngineScope scope)

at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)

at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)

at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)

at PiranhaHostingExtensions.UsePiranha(WebApplication app, Action`1 options)

at Program.
$(String[] args) in C:\Users\rafae\source\repos\RafaelGCPP\PU1OWL\PU1OWL\Program.cs:line 57

[RafaelGCPP]

After some investigation, I finally figured out it is a breaking change in EF Core 9, that doesn't like .Migrate() being called when no extra migrations are available. I'll be digging deeper, so to help create a Db class compliant with the new guidelines.

[jfaquinojr]

I spent 2 hours on this today with no luck. when I checked the clock its 1:23AM, oh well time to catch some zzzzzs

[tidyui]

Perhaps there’s a way to check if all migrations have been applied before calling .Migrate(), otherwise we could perhaps add a separate constructor that doesn’t call Migrate that can be used in the startup.

[joeylad]

Perhaps there’s a way to check if all migrations have been applied before calling .Migrate(), otherwise we could perhaps add a separate constructor that doesn’t call Migrate that can be used in the startup.

Hi Hakan I recently(yesterday) picked up the Piranha CMS and am playing around with some POCs to host a simple solution on azure, so far its been great and wanted to say well done on the project! Today I have just been trying to get PiranhaCMS up and running locally on my machine using Aspire using a PostgreSql database, opposed to the out of the box SQLLite configuration, and have been running into the exact same issue. What I did locally was set the following packages back to previous versions
Piranha.Data.EF.PostgreSql => 11.1.0
Piranha.AspNetCore.Identity.PostgreSQL => 11.1.0

Incidentally on doing that I encountered another issue where there was a problem on the ContentTypeBuilder "Cannot write DateTime with Kind=Local to PostgreSQL type 'timestamp with time zone', only UTC is supported. Note that it's not possible to mix DateTimes with different Kinds in an array, range, or multirange. " which I was able to workaround by setting the switch "AppContext.SetSwitch("Npgsql.EnableLegacyTimestampBehavior", true);" immediately before.

I have yet to get the seed data up and running locally with Aspire but I am making progress, next up is emulating blob storage.