Adapt toolbar button colors for dark theme-color on pre-macOS 26

When the article's theme-color is dark, toolbar buttons become invisible
against the dark background on pre-macOS 26 (macOS 26 handles this via
liquid glass). Apply .environment(\.colorScheme, .dark) to toolbar item
groups so buttons use proper system dark mode styling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: livid

Planet/Helper/ThemeColorExtractor.swift

@@ -101,6 +101,13 @@ struct ThemeColorExtractor {
         return NSColor(srgbRed: r, green: g, blue: b, alpha: 1.0)
     }
 
+    /// Returns true if the color's perceived luminance is dark.
+    static func isDark(_ color: NSColor) -> Bool {
+        guard let c = color.usingColorSpace(.sRGB) else { return false }
+        let luminance = 0.299 * c.redComponent + 0.587 * c.greenComponent + 0.114 * c.blueComponent
+        return luminance < 0.5
+    }
+
     // MARK: - Private Helpers
 
     private static func readHead(of url: URL, maxBytes: Int) -> Data? {

Planet/Views/Articles/ArticleView.swift

@@ -307,113 +307,122 @@ struct ArticleView: View {
         .toolbar {
             ToolbarItemGroup(placement: .automatic) {
                 // Functions for the current selected planet
-                toolbarPlanetView()
-                toolbarArticlePlanetAvatarView()
+                Group {
+                    toolbarPlanetView()
+                    toolbarArticlePlanetAvatarView()
+                }
+                .darkThemeToolbarStyle(isDarkThemeColor)
             }
 
             ToolbarItemGroup(placement: .automatic) {
                 Spacer()
-                if let article = planetStore.selectedArticle {
-                    Menu {
-                        ArticleSetStarView(article: article)
-                    } label: {
-                        ArticleToolbarStarView(article: article)
+                Group {
+                    if let article = planetStore.selectedArticle {
+                        Menu {
+                            ArticleSetStarView(article: article)
+                        } label: {
+                            ArticleToolbarStarView(article: article)
+                        }
                     }
-                }
-
-                if let article = planetStore.selectedArticle,
-                    article.hasAudio
-                {
-                    toolbarAudioView(article: article)
-                }
 
-                // Menu for accessing the attachments if any
-                if let article = planetStore.selectedArticle, let attachments = article.attachments,
-                    attachments.count > 0
-                {
-                    toolbarAttachmentsView(article: article)
-                }
+                    if let article = planetStore.selectedArticle,
+                        article.hasAudio
+                    {
+                        toolbarAudioView(article: article)
+                    }
 
-                if (settingsAIIsReady || isOnDeviceAIAvailable), let article = planetStore.selectedArticle {
-                    Button {
-                        ArticleAIChatWindowManager.shared.open(for: article)
-                    } label: {
-                        HStack(spacing: 4) {
-                            Image(systemName: "sparkles")
-                            if aiChatResponseCount > 0 {
-                                Text("\(aiChatResponseCount)")
-                                    .font(.caption)
-                                    .foregroundStyle(.secondary)
-                            }
-                        }
+                    // Menu for accessing the attachments if any
+                    if let article = planetStore.selectedArticle, let attachments = article.attachments,
+                        attachments.count > 0
+                    {
+                        toolbarAttachmentsView(article: article)
                     }
-                    .help("Chat with AI about this article")
-                }
 
-                if let followingArticle = planetStore.selectedArticle as? FollowingArticleModel {
-                    if followingArticle.supportsReaderView {
+                    if (settingsAIIsReady || isOnDeviceAIAvailable), let article = planetStore.selectedArticle {
                         Button {
-                            setReaderViewEnabled(!showLocalRendered, for: followingArticle.planet)
-                            syncSelectedArticlePresentation()
+                            ArticleAIChatWindowManager.shared.open(for: article)
                         } label: {
-                            Image(systemName: showLocalRendered ? "globe" : "doc.richtext")
+                            HStack(spacing: 4) {
+                                Image(systemName: "sparkles")
+                                if aiChatResponseCount > 0 {
+                                    Text("\(aiChatResponseCount)")
+                                        .font(.caption)
+                                        .foregroundStyle(.secondary)
+                                }
+                            }
                         }
-                        .help(showLocalRendered ? "Show Original Website" : "Show Reader View")
+                        .help("Chat with AI about this article")
                     }
 
-                    if followingArticle.supportsReadAloud {
-                        Button {
-                            toggleSpeechPlayback(for: followingArticle)
-                        } label: {
-                            Image(systemName: speechPlayerViewModel.isSpeaking ? "speaker.wave.2.fill" : "speaker.wave.2")
+                    if let followingArticle = planetStore.selectedArticle as? FollowingArticleModel {
+                        if followingArticle.supportsReaderView {
+                            Button {
+                                setReaderViewEnabled(!showLocalRendered, for: followingArticle.planet)
+                                syncSelectedArticlePresentation()
+                            } label: {
+                                Image(systemName: showLocalRendered ? "globe" : "doc.richtext")
+                            }
+                            .help(showLocalRendered ? "Show Original Website" : "Show Reader View")
                         }
-                        .disabled(detectedSpeechLanguage == nil)
-                        .help(speechPlaybackHelpText())
-                    }
-                }
 
-                if let article = planetStore.selectedArticle as? MyArticleModel, !article.isAggregated() {
-                    Button {
-                        do {
-                            try WriterStore.shared.editArticle(for: article)
+                        if followingArticle.supportsReadAloud {
+                            Button {
+                                toggleSpeechPlayback(for: followingArticle)
+                            } label: {
+                                Image(systemName: speechPlayerViewModel.isSpeaking ? "speaker.wave.2.fill" : "speaker.wave.2")
+                            }
+                            .disabled(detectedSpeechLanguage == nil)
+                            .help(speechPlaybackHelpText())
                         }
-                        catch {
-                            PlanetStore.shared.alert(title: "Failed to launch writer")
+                    }
+
+                    if let article = planetStore.selectedArticle as? MyArticleModel, !article.isAggregated() {
+                        Button {
+                            do {
+                                try WriterStore.shared.editArticle(for: article)
+                            }
+                            catch {
+                                PlanetStore.shared.alert(title: "Failed to launch writer")
+                            }
+                        } label: {
+                            Image(systemName: "pencil.line")
                         }
-                    } label: {
-                        Image(systemName: "pencil.line")
+                        .help("Edit Selected Article")
+                        .keyboardShortcut("e", modifiers: [.command])
                     }
-                    .help("Edit Selected Article")
-                    .keyboardShortcut("e", modifiers: [.command])
                 }
+                .darkThemeToolbarStyle(isDarkThemeColor)
             }
 
             ToolbarItemGroup(placement: .automatic) {
                 Spacer()
-                Button {
-                    planetStore.isShowingSearch = true
-                } label: {
-                    Image(systemName: "magnifyingglass")
-                }
-                .help("Search")
-                .keyboardShortcut("f", modifiers: [.command])
-
-                if let _ = planetStore.selectedArticle {
+                Group {
                     Button {
-                        isSharing = true
+                        planetStore.isShowingSearch = true
                     } label: {
-                        Image(systemName: "square.and.arrow.up")
+                        Image(systemName: "magnifyingglass")
                     }
-                    .background(
-                        SharingServicePicker(
-                            isPresented: $isSharing,
-                            sharingItems: [
-                                sharingItem ?? URL(string: "https://planetable.eth.limo")!
-                            ]
+                    .help("Search")
+                    .keyboardShortcut("f", modifiers: [.command])
+
+                    if let _ = planetStore.selectedArticle {
+                        Button {
+                            isSharing = true
+                        } label: {
+                            Image(systemName: "square.and.arrow.up")
+                        }
+                        .background(
+                            SharingServicePicker(
+                                isPresented: $isSharing,
+                                sharingItems: [
+                                    sharingItem ?? URL(string: "https://planetable.eth.limo")!
+                                ]
+                            )
                         )
-                    )
-                    .help("Share Selected Article")
+                        .help("Share Selected Article")
+                    }
                 }
+                .darkThemeToolbarStyle(isDarkThemeColor)
             }
         }
     }
@@ -690,6 +699,11 @@ struct ArticleView: View {
         )
     }
 
+    private var isDarkThemeColor: Bool {
+        guard let color = themeColor else { return false }
+        return ThemeColorExtractor.isDark(color)
+    }
+
     private func reExtractThemeColor() {
         guard url.isFileURL else { return }
         themeColor = ThemeColorExtractor.extractColor(from: url)
@@ -1041,3 +1055,16 @@ struct ArticleView: View {
         }
     }
 }
+
+private extension View {
+    @ViewBuilder
+    func darkThemeToolbarStyle(_ isDark: Bool) -> some View {
+        if #available(macOS 26, *) {
+            self
+        } else if isDark {
+            self.environment(\.colorScheme, .dark)
+        } else {
+            self
+        }
+    }
+}

Planet/versioning.xcconfig

@@ -1 +1 @@
-CURRENT_PROJECT_VERSION = 2797
+CURRENT_PROJECT_VERSION = 2798