Minor JS updates.

Summary:
fixes T2211
But not really.  We've decided that the JS testing is broken beyond repair, and the cost/benefit has exceeded usefulness.
The example uses the CDN which is slightly better practice than adding the script files,
and we report slightly better info about when tests finish in the example.

Test Plan: none, because we removed it :(

Reviewers: #devtools_in-progress, zac-playfab

Reviewed By: #devtools_in-progress, zac-playfab

Subscribers: zac-playfab

Maniphest Tasks: T2211

Differential Revision: https://phab.playfabdev.com/D2460

Author: pgilmorepf

targets/javascript/source/PlayFabApiTest.html

@@ -10,10 +10,10 @@
     <div id="qunit-fixture"></div>
     <script src="https://code.jquery.com/jquery-1.7.1.min.js"></script><!-- HTTP vs HTTPS here should match where this file is hosted (This file is not strictly meant to be hosted, but rather run locally) -->
     <script src="code.jquery.com/qunit/qunit-1.19.0.js"></script>
-    <script src="PlayFabSDK/PlayFabAdminApi.js"></script>
-    <script src="PlayFabSDK/PlayFabClientApi.js"></script>
-    <script src="PlayFabSDK/PlayFabMatchmakerApi.js"></script>
-    <script src="PlayFabSDK/PlayFabServerApi.js"></script>
+    <script src="https://download.playfab.com/PlayFabAdminApi.js"></script>
+    <script src="https://download.playfab.com/PlayFabClientApi.js"></script>
+    <script src="https://download.playfab.com/PlayFabMatchmakerApi.js"></script>
+    <script src="https://download.playfab.com/PlayFabServerApi.js"></script>
     <script src="PlayFabApiTest.js"></script>
 </body>
 </html>

targets/javascript/source/PlayFabApiTest.js

@@ -588,11 +588,17 @@ QUnit.done(function (details) {
         FunctionParameter: { customId: PlayFab._internalSettings.buildIdentifier, testReport: PfTestReport },
         GeneratePlayStreamEvent: true
     };
+    var onSaveResultsFinal = function (result, error) {
+        if (result && !error) {
+            console.log(PlayFabApiTests.testData.playFabId, ", Test report saved to CloudScript: ", PlayFab._internalSettings.buildIdentifier, "\n", JSON.stringify(PfTestReport, null, 4));
+        } else {
+            console.log(PlayFabApiTests.testData.playFabId, ", Failed to save test report to CloudScript (CS Error): ", PlayFab._internalSettings.buildIdentifier, "\n", JSON.stringify(PfTestReport, null, 4));
+        }
+    };
     if (PlayFabClientSDK.IsClientLoggedIn()) {
-        PlayFabClientSDK.ExecuteCloudScript(saveResultsRequest, null);
-        console.log(PlayFabApiTests.testData.playFabId, ", Test report saved to CloudScript: ", PlayFab._internalSettings.buildIdentifier, "\n", JSON.stringify(PfTestReport, null, 4));
+        PlayFabClientSDK.ExecuteCloudScript(saveResultsRequest, onSaveResultsFinal);
     } else {
-        console.log(PlayFabApiTests.testData.playFabId, ", Failed to save test report to CloudScript: ", PlayFab._internalSettings.buildIdentifier, "\n", JSON.stringify(PfTestReport, null, 4));
+        console.log(PlayFabApiTests.testData.playFabId, ", Failed to save test report to CloudScript (Login): ", PlayFab._internalSettings.buildIdentifier, "\n", JSON.stringify(PfTestReport, null, 4));
     }
 });