refactor: move time formatting utils to analyze

Author: PlexSheep

src/analyze.rs

@@ -29,9 +29,9 @@
 //! - Outage analysis
 //! - Store metadata (hashes, versions)
 
+use chrono::{DateTime, Local};
 use deepsize::DeepSizeOf;
 
-use crate::common::fmt_timestamp;
 use crate::errors::AnalysisError;
 use crate::records::{Check, CheckType, IpType};
 use crate::store::Store;
@@ -40,6 +40,16 @@ use std::fmt::{Display, Write};
 use std::hash::Hash;
 use std::os::unix::fs::MetadataExt;
 
+/// Formatting rules for timestamps that are easily readable by humans.
+///
+/// ```rust
+/// use chrono::{DateTime, Local};
+/// # use netpulse::analyze::TIME_FORMAT_HUMANS;
+/// let datetime: DateTime<Local> = Local::now();
+/// println!("it is now: {}", datetime.format(TIME_FORMAT_HUMANS));
+/// ```
+pub const TIME_FORMAT_HUMANS: &str = "%Y-%m-%d %H:%M:%S %Z";
+
 /// Represents a period of consecutive failed checks.
 ///
 /// An outage is defined by:
@@ -150,6 +160,28 @@ pub fn analyze(store: &Store) -> Result<String, AnalysisError> {
     Ok(f)
 }
 
+/// Formats a [SystemTime](std::time::SystemTime) as an easily readable timestamp for humans.
+///
+/// Works with [`std::time::SystemTime`] and [`chrono::DateTime<Local>`].
+///
+/// # Examples
+///
+/// ```rust
+/// # use netpulse::analyze::fmt_timestamp;
+/// use std::time::SystemTime;
+/// use chrono;
+/// let datetime: SystemTime = SystemTime::now();
+/// println!("it is now: {}", fmt_timestamp(datetime));
+/// let datetime: chrono::DateTime<chrono::Local> = chrono::Local::now();
+/// println!("it is now: {}", fmt_timestamp(datetime));
+/// let datetime: chrono::DateTime<chrono::Utc> = chrono::Utc::now();
+/// println!("it is now: {}", fmt_timestamp(datetime));
+/// ```
+pub fn fmt_timestamp(timestamp: impl Into<DateTime<Local>>) -> String {
+    let a: chrono::DateTime<chrono::Local> = timestamp.into();
+    format!("{}", a.format(TIME_FORMAT_HUMANS))
+}
+
 /// Adds a section divider to the report with a title.
 ///
 /// Creates a divider line of '=' characters with the title centered.

src/common.rs

@@ -39,22 +39,12 @@ use std::str::FromStr;
 
 use crate::DAEMON_PID_FILE;
 
-use chrono::{DateTime, Local};
 use getopts::Options;
 use tracing::{error, info, trace};
 use tracing_subscriber::FmtSubscriber;
 
 /// Environment variable name for configuring log level
 pub const ENV_LOG_LEVEL: &str = "NETPULSE_LOG_LEVEL";
-/// Formatting rules for timestamps that are easily readable by humans.
-///
-/// ```rust
-/// use chrono::{DateTime, Local};
-/// # use netpulse::common::TIME_FORMAT_HUMANS;
-/// let datetime: DateTime<Local> = Local::now();
-/// println!("it is now: {}", datetime.format(TIME_FORMAT_HUMANS));
-/// ```
-pub const TIME_FORMAT_HUMANS: &str = "%Y-%m-%d %H:%M:%S %Z";
 
 /// Ensures the program is running with root privileges.
 ///
@@ -272,28 +262,6 @@ pub fn getpid() -> Option<i32> {
     }
 }
 
-/// Formats a [SystemTime](std::time::SystemTime) as an easily readable timestamp for humans.
-///
-/// Works with [`std::time::SystemTime`] and [`chrono::DateTime<Local>`].
-///
-/// # Examples
-///
-/// ```rust
-/// # use netpulse::common::fmt_timestamp;
-/// use std::time::SystemTime;
-/// use chrono;
-/// let datetime: SystemTime = SystemTime::now();
-/// println!("it is now: {}", fmt_timestamp(datetime));
-/// let datetime: chrono::DateTime<chrono::Local> = chrono::Local::now();
-/// println!("it is now: {}", fmt_timestamp(datetime));
-/// let datetime: chrono::DateTime<chrono::Utc> = chrono::Utc::now();
-/// println!("it is now: {}", fmt_timestamp(datetime));
-/// ```
-pub fn fmt_timestamp(timestamp: impl Into<DateTime<Local>>) -> String {
-    let a: chrono::DateTime<chrono::Local> = timestamp.into();
-    format!("{}", a.format(TIME_FORMAT_HUMANS))
-}
-
 /// Sets up a custom panic handler for user-friendly error reporting.
 ///
 /// Should be called early in the program startup, ideally before any other operations.

src/records.rs

@@ -48,7 +48,7 @@ use flagset::{flags, FlagSet};
 use serde::{Deserialize, Serialize};
 use tracing::error;
 
-use crate::common::fmt_timestamp;
+use crate::analyze::fmt_timestamp;
 use crate::errors::StoreError;
 use crate::store::Version;