transcript refactor (#103)

* wip

wip

wip

wip

update

fmt

wip

update CI

ipdate

simplify CI

fix

fix

add arith

reenable bench

wip

almost there

clippy and fmt

more fixes

fmt

wip

fix neon

Update rust-toolchain

wip

older nightly version

fix bench module

update CI (#102)

* update CI

* ipdate

* simplify CI

* fix

* fix

* add arith

* reenable bench

remove avx512 instructions from avx256 (#94)

Signed-off-by: Tiancheng Xie <[email protected]>
Co-authored-by: siq1 <[email protected]>
Co-authored-by: Tiancheng Xie <[email protected]>

transcript crate

refactoring transcript

* fmt

fmt

Author: zhenfeizhang

.github/workflows/ci.yml

@@ -85,4 +85,4 @@ jobs:
         run: |
           python3 ./scripts/install.py
           cargo run --bin=dev-setup --release
-          cargo run --release -- -t ${{ matrix.os == 'macos-latest' && 2 || 16 }} -f ${{ matrix.field }}
+          cargo run --release -- -t ${{ matrix.os == 'macos-latest' && 2 || 16 }} -f ${{ matrix.field }}

Cargo.toml

@@ -9,6 +9,7 @@ arith = { path = "arith" }
 gf2 = { path = "arith/gf2" }
 gf2_128 = { path = "arith/gf2_128" }
 mersenne31 = { path = "arith/mersenne31" }
+transcript = { path = "transcript" }
 
 ark-std.workspace = true
 clap.workspace = true
@@ -55,8 +56,9 @@ members = [
     "arith/gf2_128",
     "arith/goldilocks",
     "arith/mersenne31",
-    "bi-kzg"
-    ]
+    "bi-kzg",
+    "transcript"
+]
 
 [workspace.dependencies]
 ark-std = "0.4"

src/circuit/expander_circuit.rs

@@ -1,8 +1,10 @@
 use arith::Field;
 use ark_std::test_rng;
+use transcript::Transcript;
+use transcript::TranscriptInstance;
 
 use crate::circuit::*;
-use crate::{GKRConfig, Transcript};
+use crate::GKRConfig;
 
 #[derive(Debug, Clone, Default)]
 pub struct StructureInfo {
@@ -177,11 +179,11 @@ impl<C: GKRConfig> Circuit<C> {
         self.rnd_coefs_identified = true;
     }
 
-    pub fn fill_rnd_coefs(&mut self, transcript: &mut Transcript<C::FiatShamirHashType>) {
+    pub fn fill_rnd_coefs(&mut self, transcript: &mut TranscriptInstance<C::FiatShamirHashType>) {
         assert!(self.rnd_coefs_identified);
         for &rnd_coef_ptr in &self.rnd_coefs {
             unsafe {
-                *rnd_coef_ptr = transcript.circuit_f::<C>();
+                *rnd_coef_ptr = transcript.generate_challenge::<C::CircuitField>();
             }
         }
     }

src/config/gkr_config.rs

@@ -4,9 +4,8 @@ mod gf2_ext_keccak;
 mod gf2_ext_sha2;
 mod m31_ext_keccak;
 mod m31_ext_sha2;
-
-use crate::FiatShamirHash;
 use arith::{ExtensionField, Field, FieldSerde, SimdField};
+use transcript::FiatShamirHash;
 
 pub use bn254_keccak::BN254ConfigKeccak;
 pub use bn254_sha2::BN254ConfigSha2;

src/config/gkr_config/bn254_keccak.rs

@@ -1,6 +1,5 @@
 use halo2curves::bn256::Fr;
-
-use crate::Keccak256hasher;
+use transcript::Keccak256hasher;
 
 use super::{FieldType, GKRConfig};
 

src/config/gkr_config/bn254_sha2.rs

@@ -1,6 +1,5 @@
 use halo2curves::bn256::Fr;
-
-use crate::SHA256hasher;
+use transcript::SHA256hasher;
 
 use super::{FieldType, GKRConfig};
 

src/config/gkr_config/gf2_ext_keccak.rs

@@ -1,8 +1,7 @@
 use arith::ExtensionField;
 use gf2::{GF2x8, GF2};
 use gf2_128::{GF2_128x8, GF2_128};
-
-use crate::Keccak256hasher;
+use transcript::Keccak256hasher;
 
 use super::{FieldType, GKRConfig};
 

src/config/gkr_config/gf2_ext_sha2.rs

@@ -1,8 +1,7 @@
 use arith::ExtensionField;
 use gf2::{GF2x8, GF2};
 use gf2_128::{GF2_128x8, GF2_128};
-
-use crate::SHA256hasher;
+use transcript::SHA256hasher;
 
 use super::{FieldType, GKRConfig};
 

src/config/gkr_config/m31_ext_keccak.rs

@@ -1,7 +1,6 @@
 use arith::ExtensionField;
 use mersenne31::{M31Ext3, M31Ext3x16, M31x16, M31};
-
-use crate::Keccak256hasher;
+use transcript::Keccak256hasher;
 
 use super::{FieldType, GKRConfig};
 

src/config/gkr_config/m31_ext_sha2.rs

@@ -1,7 +1,6 @@
 use arith::ExtensionField;
 use mersenne31::{M31Ext3, M31Ext3x16, M31x16, M31};
-
-use crate::SHA256hasher;
+use transcript::SHA256hasher;
 
 use super::{FieldType, GKRConfig};