move crate level tensor-code-iop based PCS to trait.rs

Author: tonyfloatersu

pcs/src/orion.rs

@@ -10,7 +10,7 @@ use transcript::Transcript;
 use crate::PolynomialCommitmentScheme;
 
 mod utils;
-pub use utils::{OrionPCSError, OrionResult, SubsetSumLUTs, TensorIOPPCS};
+pub use utils::{OrionPCSError, OrionResult, SubsetSumLUTs};
 
 mod linear_code;
 pub use linear_code::{OrionCodeParameter, ORION_CODE_PARAMETER_INSTANCE};

pcs/src/orion/pcs_impl.rs

@@ -4,11 +4,11 @@ use arith::{Field, FieldSerde, SimdField};
 use polynomials::{EqPolynomial, MultiLinearPoly};
 use transcript::Transcript;
 
-use crate::{orion::utils::SubsetSumLUTs, PCS_SOUNDNESS_BITS};
+use crate::{traits::TensorCodeIOPPCS, PCS_SOUNDNESS_BITS};
 
 use super::{
     linear_code::{OrionCode, OrionCodeParameter},
-    utils::{transpose_in_place, OrionPCSError, OrionResult, TensorIOPPCS},
+    utils::{transpose_in_place, OrionPCSError, OrionResult, SubsetSumLUTs},
 };
 
 /**********************************************************
@@ -21,7 +21,7 @@ pub struct OrionPublicParams {
     pub code_instance: OrionCode,
 }
 
-impl TensorIOPPCS for OrionPublicParams {
+impl TensorCodeIOPPCS for OrionPublicParams {
     fn codeword_len(&self) -> usize {
         self.code_instance.code_len()
     }
@@ -38,7 +38,6 @@ where
     ComPackF: SimdField<Scalar = F>,
 {
     pub interleaved_alphabet_tree: tree::Tree,
-
     pub _phantom: PhantomData<ComPackF>,
 }
 

pcs/src/orion/tests.rs

@@ -5,10 +5,13 @@ use ark_std::test_rng;
 use gf2::{GF2x128, GF2x512, GF2x64, GF2x8, GF2};
 use polynomials::MultiLinearPoly;
 
-use crate::orion::{
-    linear_code::{OrionCode, ORION_CODE_PARAMETER_INSTANCE},
-    pcs_impl::{OrionCommitment, OrionCommitmentWithData, OrionPublicParams},
-    utils::{transpose_in_place, SubsetSumLUTs, TensorIOPPCS},
+use crate::{
+    orion::{
+        linear_code::{OrionCode, ORION_CODE_PARAMETER_INSTANCE},
+        pcs_impl::{OrionCommitment, OrionCommitmentWithData, OrionPublicParams},
+        utils::{transpose_in_place, SubsetSumLUTs},
+    },
+    traits::TensorCodeIOPPCS,
 };
 
 fn column_combination<F, PackF>(mat: &[F], combination: &[F]) -> Vec<F>

pcs/src/orion/utils.rs

@@ -46,43 +46,6 @@ pub(crate) fn transpose_in_place<F: Field>(mat: &mut [F], scratch: &mut [F], row
     mat.copy_from_slice(scratch);
 }
 
-/**********************************
- * TENSOR IOP BASED PCS UTILITIES *
- **********************************/
-
-pub trait TensorIOPPCS {
-    fn codeword_len(&self) -> usize;
-
-    fn hamming_weight(&self) -> f64;
-
-    fn row_col_from_variables<F: Field>(num_vars: usize) -> (usize, usize) {
-        let elems_for_smallest_tree = tree::leaf_adic::<F>() * 2;
-
-        let row_num: usize = elems_for_smallest_tree;
-        let msg_size: usize = (1 << num_vars) / row_num;
-
-        (row_num, msg_size)
-    }
-
-    fn query_complexity(&self, soundness_bits: usize) -> usize {
-        // NOTE: use Ligero (AHIV22) or Avg-case dist to a code (BKS18)
-        // version of avg case dist in unique decoding technique.
-        let avg_case_dist = self.hamming_weight() / 3f64;
-        let sec_bits = -(1f64 - avg_case_dist).log2();
-
-        (soundness_bits as f64 / sec_bits).ceil() as usize
-    }
-
-    fn proximity_repetitions<F: Field>(&self, soundness_bits: usize) -> usize {
-        // NOTE: use Ligero (AHIV22) or Avg-case dist to a code (BKS18)
-        // version of avg case dist in unique decoding technique.
-        // Here is the probability union bound
-        let single_run_soundness_bits = F::FIELD_SIZE - self.codeword_len().ilog2() as usize;
-
-        (soundness_bits as f64 / single_run_soundness_bits as f64).ceil() as usize
-    }
-}
-
 /*********************
  * LINEAR OPERATIONS *
  *********************/

pcs/src/traits.rs

@@ -41,3 +41,36 @@ pub trait PolynomialCommitmentScheme {
         transcript: &mut Self::FiatShamirTranscript,
     ) -> bool;
 }
+
+pub(crate) trait TensorCodeIOPPCS {
+    fn codeword_len(&self) -> usize;
+
+    fn hamming_weight(&self) -> f64;
+
+    fn row_col_from_variables<F: Field>(num_vars: usize) -> (usize, usize) {
+        let elems_for_smallest_tree = tree::leaf_adic::<F>() * 2;
+
+        let row_num: usize = elems_for_smallest_tree;
+        let msg_size: usize = (1 << num_vars) / row_num;
+
+        (row_num, msg_size)
+    }
+
+    fn query_complexity(&self, soundness_bits: usize) -> usize {
+        // NOTE: use Ligero (AHIV22) or Avg-case dist to a code (BKS18)
+        // version of avg case dist in unique decoding technique.
+        let avg_case_dist = self.hamming_weight() / 3f64;
+        let sec_bits = -(1f64 - avg_case_dist).log2();
+
+        (soundness_bits as f64 / sec_bits).ceil() as usize
+    }
+
+    fn proximity_repetitions<F: Field>(&self, soundness_bits: usize) -> usize {
+        // NOTE: use Ligero (AHIV22) or Avg-case dist to a code (BKS18)
+        // version of avg case dist in unique decoding technique.
+        // Here is the probability union bound
+        let single_run_soundness_bits = F::FIELD_SIZE - self.codeword_len().ilog2() as usize;
+
+        (soundness_bits as f64 / single_run_soundness_bits as f64).ceil() as usize
+    }
+}