Skip to content

Commit bbbc463

Browse files
committed
chore: remove dummy simd impls
1 parent 56f31a2 commit bbbc463

File tree

2 files changed

+2
-50
lines changed

2 files changed

+2
-50
lines changed

arith/src/extension_field/baby_bear_ext3.rs

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
use super::ExtensionField;
2-
use crate::{
3-
field_common, BabyBear, Field, FieldSerde, FieldSerdeResult, SimdField, BABYBEAR_MODULUS,
4-
};
2+
use crate::{field_common, BabyBear, Field, FieldSerde, FieldSerdeResult, BABYBEAR_MODULUS};
53
use core::{
64
iter::{Product, Sum},
75
ops::{Add, AddAssign, Mul, MulAssign, Neg, Sub, SubAssign},
@@ -175,29 +173,6 @@ impl ExtensionField for BabyBearExt3 {
175173
}
176174
}
177175

178-
// TODO: Actual SIMD impl
179-
// This is a dummy implementation to satisfy trait bounds
180-
impl SimdField for BabyBearExt3 {
181-
type Scalar = Self;
182-
183-
fn scale(&self, challenge: &Self::Scalar) -> Self {
184-
self * challenge
185-
}
186-
187-
fn pack(base_vec: &[Self::Scalar]) -> Self {
188-
debug_assert!(base_vec.len() == 1);
189-
base_vec[0]
190-
}
191-
192-
fn unpack(&self) -> Vec<Self::Scalar> {
193-
vec![*self]
194-
}
195-
196-
fn pack_size() -> usize {
197-
1
198-
}
199-
}
200-
201176
impl Add<BabyBear> for BabyBearExt3 {
202177
type Output = Self;
203178

arith/src/extension_field/baby_bear_ext4.rs

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use super::ExtensionField;
2-
use crate::{field_common, BabyBear, Field, FieldSerde, FieldSerdeResult, SimdField};
2+
use crate::{field_common, BabyBear, Field, FieldSerde, FieldSerdeResult};
33
use core::{
44
iter::{Product, Sum},
55
ops::{Add, AddAssign, Mul, MulAssign, Neg, Sub, SubAssign},
@@ -199,29 +199,6 @@ impl ExtensionField for BabyBearExt4 {
199199
}
200200
}
201201

202-
// TODO: Actual SIMD impl
203-
// This is a dummy implementation to satisfy trait bounds
204-
impl SimdField for BabyBearExt4 {
205-
type Scalar = Self;
206-
207-
fn scale(&self, challenge: &Self::Scalar) -> Self {
208-
self * challenge
209-
}
210-
211-
fn pack(base_vec: &[Self::Scalar]) -> Self {
212-
debug_assert!(base_vec.len() == 1);
213-
base_vec[0]
214-
}
215-
216-
fn unpack(&self) -> Vec<Self::Scalar> {
217-
vec![*self]
218-
}
219-
220-
fn pack_size() -> usize {
221-
1
222-
}
223-
}
224-
225202
impl Add<BabyBear> for BabyBearExt4 {
226203
type Output = Self;
227204

0 commit comments

Comments
 (0)