-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code refactor #115
Merged
Merged
code refactor #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhenfeizhang
commented
Oct 8, 2024
•
edited
Loading
edited
- refactor Polynomials module
- refactor Sumcheck module
- fix CI
- added various unit tests and benchmarks polynomial eval tests #116
zhenfeizhang
force-pushed
the
zz/refactor_polynomials
branch
from
October 10, 2024 20:06
71bc000
to
ede37cc
Compare
niconiconi
pushed a commit
that referenced
this pull request
Oct 16, 2024
* code refactor (#115) * wip * refactor eq poly * wip * fix tests * wip * wip * minor refactoring * wip * simplify proof * more refactoring * wip * wip * more edits * wip * bench polynomials * wip * improving polynomial * fmt * ping specific version of openmpi * fix ci * commit cargo lock * try fix * try again * Update ci.yml * Update ci.yml * clean up * lint * Zz/fix poseidon witnesses (#118) * fix poseidon witnesses * wip * fix all binaries * add e2e CI * use 7950x3d * fix circuit * update ci * mpi chunk size * clippy * update branch for scripts (#120) * Mpi chunk size (#121) * mpi chunk size * clippy * fix a correctness problem * fix a problem in mpi chunk size * Fix expander-exec (#122) * fix expander-exec * fix * Update readme.md --------- Co-authored-by: zhenfei <[email protected]> * fix mpi (#124) * fix mpi * add tests in e2e * fix * optimize expander eq * minor --------- Signed-off-by: Zhiyong Fang <[email protected]> Co-authored-by: Zhiyong Fang <[email protected]> Co-authored-by: mcfx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.