3032 gobierto data add custom field license for dataset #3821

stbnrivas · 2021-04-15T12:01:44Z

✌️ What does this PR do?

add to module GobiertoData (for every dataset)

new vocabulary license: Open Data (ODbl), Open Data (ODC-By), Open Data (PDDL)
new custom_field source (source of data were obtained )
new custom_field source-url (url to the font)

refactor zeitwerk compliance remove dirs db/seeds/modules to db/seeds/gobierto_seeds/

🔍 How should this be manually tested?

for Gobierto installation with existing sites which module GobiertoData are enabled, new custom fields should be enable after apply
for Gobierto installation without existing sites, you should run a feed from console, to enable new custom fields

bin/rails c
site = Site.find_by(domain: "madrid.gobierto.test")
GobiertoSeeds::GobiertoData::Recipe.run(site) if site.configuration.gobierto_data_enabled?

refactor mv for db/seeds/modules to db/seeds/gobierto_seeds/gobierto_{data,people,plans}

bin/rails c
site = Site.find_by(domain: "madrid.gobierto.test")
GobiertoSeeds::GobiertoPeople::Recipe.run(site)
GobiertoSeeds::GobiertoPlans::Recipe.run(site)

👀 Screenshots

Before this PR

After this PR

…ata Module is enabled

ferblape · 2021-04-19T05:42:20Z

app/javascript/gobierto_data/webapp/components/commons/Info.vue

@@ -22,6 +22,27 @@
        :label="labelSubject"
        :text="categoryDataset"
      />
+      <InfoBlockText


@Crashillo @stbnrivas it would be good to show both source text and url as a link (with target blank), and not in two separated fields, don't you think?

In order to do so, you should either create a new component or parametrize the current one

yes, could you help @stbnrivas ?

we already create a new component to show as a link . Also I opened a new issue with another way to do it.

#3830

ferblape · 2021-04-19T05:44:46Z

db/seeds/gobierto_seeds/gobierto_data/recipe.rb

+          if vocabulary.new_record?
+            vocabulary.name_translations = { ca: "Llicència", en: "License", es: "Licencia" }
+            vocabulary.save
+            vocabulary.terms.create(name_translations: { ca: "Open Data (ODbl)",   en: "Open Data (ODbl)",   es: "Open Data (ODbl)" }, position: 1)


I'd add an option for not known (maybe the first option or default)

can I name as:

ca: "Llicència desconeguda"
en: "Unknown license"
es: "Licencia desconocida"

I think it would be better to allow to not select a value, and if so, don't show the field.

ferblape · 2021-04-19T05:45:16Z

db/seeds/gobierto_seeds/gobierto_data/recipe.rb

+          dataset_source_url.save
+        end
+
+        licenses = site.custom_fields.vocabulary_options.where(class_name: "GobiertoData::Dataset").find_or_initialize_by(uid: 'dataset-license')


why plural name in the variable?

Crashillo · 2021-04-19T15:32:35Z

config/locales/defaults/ca.yml

@@ -15,7 +15,7 @@ ca:
    - dv
    - ds
    abbr_month_names:
-    -
+    - 


@ferblape is it possible that this always happen due to the missing tabulator char? Perhaps, should it be??

abbr_month_names: - gen - feb

Just asking

I'm not sure if the guilty is:

husky > pre-commit (node v14.16.1)
✔ Preparing...
❯ Running tasks...
↓ No staged files match app/javascript//*.{js,vue} [SKIPPED]
↓ No staged files match app//.{css,scss} [SKIPPED]
❯ Running tasks for config/locales/**/.yml
⠇ npm run check_i18n
◼ Applying modifications...
◼ Cleaning up...

Another guilty is my Atom default configuration because. Atom is removing all withespaces at end of line every time that save the file.

I will disable (auto delete end whitespaces)
https://flight-manual.atom.io/using-atom/sections/editing-and-deleting-text/#whitespace

I will enable highlights spaces like this
https://atom.io/packages/trailing-spaces

No, no, we know the check_i18n script is the reason to set/unset the tabulation. But it's a recurrent issue that I cannot figure out how it happens, sometimes there's empty row, sometimes there isn't :(

it's not an empty row but an empty space in the row, I don't know what causes it, probably an editor linter?

Crashillo · 2021-04-19T15:42:39Z

config/locales/gobierto_data/views/en.yml

+      sourceDataset: Font
+      sourceDatasetUrl: Font url


Suggested change

sourceDataset: Font

sourceDatasetUrl: Font url

sourceDataset: Source

sourceDatasetUrl: Source url

Crashillo · 2021-04-19T15:43:38Z

config/locales/gobierto_data/views/es.yml

@@ -68,6 +69,8 @@ es:
      sets: Conjuntos
      showAll: Ver todo
      showLess: Ver menos
+      sourceDataset: Fuente
+      sourceDatasetUrl: Link Fuente


Keep the consistency between translations, use Fuente url instead

ferblape · 2021-04-20T02:51:24Z

test/services/gobierto_common/gobierto_seeder/module_seeder_test.rb

@@ -26,6 +27,7 @@ def site

  def test_seed_a_site_with_that_module
    @subject.seed("GobiertoPeople", site)
+    byebug


stbnrivas added 2 commits April 15, 2021 07:52

add custom_field license into backoffice for all site which GobiertoD…

19c9aec

…ata Module is enabled

show custom_field license at front office

e52ada2

stbnrivas force-pushed the 3032-gobierto-data-add-custom-field-license-for-dataset branch from 21b0dfd to e52ada2 Compare April 15, 2021 12:15

stbnrivas added 2 commits April 16, 2021 10:36

fix forgotten required path

2da38f4

adding license, source, source_url to dataset

3be2115

stbnrivas force-pushed the 3032-gobierto-data-add-custom-field-license-for-dataset branch from 7afe511 to 3be2115 Compare April 16, 2021 10:45

stbnrivas added 2 commits April 16, 2021 18:24

refactor zeitwerk compliance db/seeds/gobierto_seeds/

162642e

add a InfoBlockLink.vue to show as a link

ec17514

ferblape requested changes Apr 19, 2021

View reviewed changes

add new licenses (used datos.gob.es), fix i18n dataset_source_url

910e73d

Crashillo suggested changes Apr 19, 2021

View reviewed changes

stbnrivas force-pushed the 3032-gobierto-data-add-custom-field-license-for-dataset branch from 7774f61 to 69d8fbc Compare April 19, 2021 17:51

ferblape reviewed Apr 20, 2021

View reviewed changes

Crashillo approved these changes Apr 20, 2021

View reviewed changes

stbnrivas force-pushed the 3032-gobierto-data-add-custom-field-license-for-dataset branch from 69d8fbc to c36caa3 Compare April 20, 2021 08:49

fixing test after refactor services gobierto seeder

2ba5088

stbnrivas force-pushed the 3032-gobierto-data-add-custom-field-license-for-dataset branch from c36caa3 to 2ba5088 Compare April 20, 2021 10:55

ferblape approved these changes Apr 22, 2021

View reviewed changes

ferblape merged commit b080e78 into master Apr 22, 2021

ferblape deleted the 3032-gobierto-data-add-custom-field-license-for-dataset branch April 22, 2021 02:54

ferblape mentioned this pull request Apr 22, 2021

Remove gobierto seeds for sites #3834

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3032 gobierto data add custom field license for dataset #3821

3032 gobierto data add custom field license for dataset #3821

stbnrivas commented Apr 15, 2021 •

edited

Loading

ferblape Apr 19, 2021

Crashillo Apr 19, 2021

ferblape Apr 19, 2021

stbnrivas Apr 19, 2021

ferblape Apr 19, 2021

stbnrivas Apr 19, 2021

ferblape Apr 19, 2021

furilo Apr 19, 2021

ferblape Apr 19, 2021

Crashillo Apr 19, 2021

stbnrivas Apr 19, 2021 •

edited

Loading

Crashillo Apr 20, 2021

ferblape Apr 20, 2021

Crashillo Apr 19, 2021

Crashillo Apr 19, 2021

ferblape Apr 20, 2021

3032 gobierto data add custom field license for dataset #3821

3032 gobierto data add custom field license for dataset #3821

Conversation

stbnrivas commented Apr 15, 2021 • edited Loading

✌️ What does this PR do?

🔍 How should this be manually tested?

👀 Screenshots

Before this PR

After this PR

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stbnrivas Apr 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stbnrivas commented Apr 15, 2021 •

edited

Loading

stbnrivas Apr 19, 2021 •

edited

Loading