From eb123bec2851f88b37936275c998ee03a3d18adf Mon Sep 17 00:00:00 2001 From: Bram Stoeller Date: Wed, 13 Jul 2022 09:20:04 +0200 Subject: [PATCH] Fix unittest and docs for tap_size Signed-off-by: Bram Stoeller --- docs/graph-data-model.md | 2 +- tests/unit/validation/test_input_validation.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/graph-data-model.md b/docs/graph-data-model.md index afa97d9b2..0563dfb5a 100644 --- a/docs/graph-data-model.md +++ b/docs/graph-data-model.md @@ -249,7 +249,7 @@ In this case the winding voltage is decreased if the tap position is increased.* | `tap_min` | `int8_t` | - | position of tap changer at minimum voltage | ✔ | ✔ | ❌ | ❌ | | | `tap_max` | `int8_t` | - | position of tap changer at maximum voltage | ✔ | ✔ | ❌ | ❌ | | | `tap_nom` | `int8_t` | - | nominal position of tap changer | ❌ default zero | ✔ | ❌ | ❌ | `(tap_min <= tap_nom <= tap_max)` or `(tap_min >= tap_nom >= tap_max)` | -| `tap_size` | `double` | volt (V) | size of each tap of the tap changer | ✔ | ✔ | ❌ | ❌ | `> 0` | +| `tap_size` | `double` | volt (V) | size of each tap of the tap changer | ✔ | ✔ | ❌ | ❌ | `>= 0` | | `uk_min` | `double` | - | relative short circuit voltage at minimum tap | ❌ default same as `uk` | ✔ | ❌ | ❌ | `>= pk_min / sn` and `> 0` and `< 1` | | `uk_max` | `double` | - | relative short circuit voltage at maximum tap | ❌ default same as `uk` | ✔ | ❌ | ❌ | `>= pk_max / sn` and `> 0` and `< 1` | | `pk_min` | `double` | watt (W) | short circuit (copper) loss at minimum tap | ❌ default same as `pk` | ✔ | ❌ | ❌ | `>= 0` | diff --git a/tests/unit/validation/test_input_validation.py b/tests/unit/validation/test_input_validation.py index 296041b47..c12ed7016 100644 --- a/tests/unit/validation/test_input_validation.py +++ b/tests/unit/validation/test_input_validation.py @@ -242,7 +242,7 @@ def test_validate_input_data_sym_calculation(input_data): assert NotBetweenOrAtError("transformer", "clock", [1, 14], (0, 12)) in validation_errors assert NotBetweenOrAtError("transformer", "tap_pos", [14, 15], ("tap_min", "tap_max")) in validation_errors assert NotBetweenOrAtError("transformer", "tap_nom", [1, 15], ("tap_min", "tap_max")) in validation_errors - assert NotGreaterThanError("transformer", "tap_size", [14, 15], 0) in validation_errors + assert NotGreaterOrEqualError("transformer", "tap_size", [15], 0) in validation_errors assert NotGreaterOrEqualError("transformer", "uk_min", [1], "pk_min/sn") in validation_errors assert NotBetweenError("transformer", "uk_min", [14], (0, 1)) in validation_errors assert NotGreaterOrEqualError("transformer", "uk_max", [1], "pk_max/sn") in validation_errors