Skip to content

Commit f6a751c

Browse files
committed
Attempt to re-enable WarningsAsErrors for documentation comments
See #353 for more details on why this doesn't work currently.
1 parent 2f793ba commit f6a751c

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/PowerShellEditorServices/PowerShellEditorServices.csproj

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,13 @@
3131
<DefineConstants Condition="'$(PowerShellVersion)' == 'v5r2' Or '$(PowerShellVersion)' == ''">$(DefineConstants);PowerShellv5r2;PowerShellv5</DefineConstants>
3232
</PropertyGroup>
3333

34+
<!-- Fail the release build if there are missing public API documentation comments -->
35+
<!-- TODO #353: Re-enable this once dotnet doesn't hang on these errors anymore -->
36+
<!--<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
37+
<WarningsAsErrors>1591,1573,1572</WarningsAsErrors>
38+
<DocumentationFile>bin\$(TargetFramework)\$(Configuration)\Microsoft.PowerShell.EditorServices.xml</DocumentationFile>
39+
</PropertyGroup>-->
40+
3441
<ItemGroup>
3542
<PackageReference Include="Microsoft.NET.Sdk">
3643
<Version>1.0.0-alpha-20161104-2</Version>

0 commit comments

Comments
 (0)