Skip to content

Commit 3dc11c1

Browse files
authored
Fix bugs in ShowHelp and DebugSession which broke deactivate() (#3592)
Caused by unused variables referenced only in `dispose()` methods that were transpiled out (having been unused) and so causing exceptions on disposal, stopping the completion of `deactivate()`.
1 parent 8e19010 commit 3dc11c1

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/features/DebugSession.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export class DebugSessionFeature extends LanguageClientConsumer
2525
implements DebugConfigurationProvider, vscode.DebugAdapterDescriptorFactory {
2626

2727
private sessionCount: number = 1;
28-
private command: vscode.Disposable;
2928
private tempDebugProcess: PowerShellProcess;
3029
private tempSessionDetails: utils.IEditorServicesSessionDetails;
3130

@@ -51,8 +50,8 @@ export class DebugSessionFeature extends LanguageClientConsumer
5150
return new vscode.DebugAdapterInlineImplementation(debugAdapter);
5251
}
5352

53+
// tslint:disable-next-line:no-empty
5454
public dispose() {
55-
this.command.dispose();
5655
}
5756

5857
public setLanguageClient(languageClient: LanguageClient) {

src/features/ShowHelp.ts

-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export const ShowHelpNotificationType =
1111

1212
export class ShowHelpFeature extends LanguageClientConsumer {
1313
private command: vscode.Disposable;
14-
private deprecatedCommand: vscode.Disposable;
1514

1615
constructor(private log: Logger) {
1716
super();
@@ -34,7 +33,6 @@ export class ShowHelpFeature extends LanguageClientConsumer {
3433

3534
public dispose() {
3635
this.command.dispose();
37-
this.deprecatedCommand.dispose();
3836
}
3937

4038
}

0 commit comments

Comments
 (0)