Skip to content

Commit 7e80fe5

Browse files
committed
Enable 'noImplicitAny' and 'noImplicitOverride'
1 parent 146825b commit 7e80fe5

8 files changed

+12
-11
lines changed

src/features/Console.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export class ConsoleFeature extends LanguageClientConsumer {
222222
}
223223
}
224224

225-
public setLanguageClient(languageClient: LanguageClient) {
225+
public override setLanguageClient(languageClient: LanguageClient) {
226226
this.languageClient = languageClient;
227227
this.handlers = [
228228
this.languageClient.onRequest(

src/features/CustomViews.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class CustomViewsFeature extends LanguageClientConsumer {
2727
}
2828
}
2929

30-
public setLanguageClient(languageClient: LanguageClient) {
30+
public override setLanguageClient(languageClient: LanguageClient) {
3131

3232
languageClient.onRequest(
3333
NewCustomViewRequestType,

src/features/DebugSession.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class DebugSessionFeature extends LanguageClientConsumer
9494
}
9595
}
9696

97-
public setLanguageClient(languageClient: LanguageClient) {
97+
public override setLanguageClient(languageClient: LanguageClient) {
9898
this.handlers = [
9999
languageClient.onNotification(
100100
StartDebuggerNotificationType,
@@ -366,7 +366,7 @@ export class PickPSHostProcessFeature extends LanguageClientConsumer {
366366
});
367367
}
368368

369-
public setLanguageClient(languageClient: LanguageClient) {
369+
public override setLanguageClient(languageClient: LanguageClient) {
370370
this.languageClient = languageClient;
371371

372372
if (this.waitingForClientToken && this.getLanguageClientResolve) {
@@ -488,7 +488,7 @@ export class PickRunspaceFeature extends LanguageClientConsumer {
488488
}, this);
489489
}
490490

491-
public setLanguageClient(languageClient: LanguageClient) {
491+
public override setLanguageClient(languageClient: LanguageClient) {
492492
this.languageClient = languageClient;
493493

494494
if (this.waitingForClientToken && this.getLanguageClientResolve) {

src/features/ExtensionCommands.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
222222
]
223223
}
224224

225-
public setLanguageClient(languageclient: LanguageClient) {
225+
public override setLanguageClient(languageclient: LanguageClient) {
226226
// Clear the current list of extension commands since they were
227227
// only relevant to the previous session
228228
this.extensionCommands = [];

src/features/GetCommands.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class GetCommandsFeature extends LanguageClientConsumer {
5252
this.command.dispose();
5353
}
5454

55-
public setLanguageClient(languageclient: LanguageClient) {
55+
public override setLanguageClient(languageclient: LanguageClient) {
5656
this.languageClient = languageclient;
5757
if (this.commandsExplorerTreeView.visible) {
5858
vscode.commands.executeCommand("PowerShell.RefreshCommandsExplorer");
@@ -127,7 +127,7 @@ class Command extends vscode.TreeItem {
127127
public readonly defaultParameterSet: string,
128128
public readonly ParameterSets: object,
129129
public readonly Parameters: object,
130-
public readonly collapsibleState = vscode.TreeItemCollapsibleState.None,
130+
public override readonly collapsibleState = vscode.TreeItemCollapsibleState.None,
131131
) {
132132
super(Name, collapsibleState);
133133
}

src/features/HelpCompletion.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class HelpCompletionFeature extends LanguageClientConsumer {
3535
this.disposable?.dispose();
3636
}
3737

38-
public setLanguageClient(languageClient: LanguageClient) {
38+
public override setLanguageClient(languageClient: LanguageClient) {
3939
this.languageClient = languageClient;
4040
if (this.helpCompletionProvider) {
4141
this.helpCompletionProvider.languageClient = languageClient;

src/features/NewFileOrProject.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class NewFileOrProjectFeature extends LanguageClientConsumer {
5252
this.command.dispose();
5353
}
5454

55-
public setLanguageClient(languageClient: LanguageClient) {
55+
public override setLanguageClient(languageClient: LanguageClient) {
5656
this.languageClient = languageClient;
5757

5858
if (this.waitingForClientToken) {

tsconfig.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"strict": true,
1515
"noImplicitReturns": true,
1616
"noFallthroughCasesInSwitch": true,
17-
"noUnusedParameters": true
17+
"noImplicitOverride": true,
18+
"noUnusedParameters": true,
1819
},
1920
"include": [ "src", "test" ],
2021
}

0 commit comments

Comments
 (0)