Convert TSLint to ESLint comments

Ignoring bitwise and console as they're not warnings.

Author: andyleejordan

src/controls/checkboxQuickPick.ts

@@ -66,7 +66,6 @@ async function showInner(
     if (index >= 0) {
         toggleSelection(items[index]);
     } else {
-        // tslint:disable-next-line:no-console
         console.log(`Couldn't find CheckboxQuickPickItem for label '${selection.label}'`);
     }
 

src/features/CustomViews.ts

@@ -75,7 +75,6 @@ class PowerShellContentProvider implements vscode.TextDocumentContentProvider {
     private viewIndex: { [id: string]: CustomView } = {};
     private didChangeEvent: vscode.EventEmitter<vscode.Uri> = new vscode.EventEmitter<vscode.Uri>();
 
-    // tslint:disable-next-line:member-ordering
     public onDidChange: vscode.Event<vscode.Uri> = this.didChangeEvent.event;
 
     public provideTextDocumentContent(uri: vscode.Uri): string {

src/features/ExtensionCommands.ts

@@ -79,7 +79,7 @@ export const GetEditorContextRequestType =
     new RequestType<IGetEditorContextRequestArguments, IEditorContext, void>(
         "editor/getEditorContext");
 
-// tslint:disable-next-line:no-empty-interface
+// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface IGetEditorContextRequestArguments {
 }
 

src/logging.ts

@@ -186,7 +186,6 @@ export class Logger implements ILogger {
                     this.logFilePath,
                     Buffer.concat([log, Buffer.from(timestampedMessage)]));
             } catch (e) {
-                // tslint:disable-next-line:no-console
                 console.log(`Error writing to vscode-powershell log file: ${e}`);
             }
         }

src/main.ts

@@ -32,7 +32,7 @@ import { PowerShellLanguageId } from "./utils";
 import { LanguageClientConsumer } from "./languageClientConsumer";
 
 // The most reliable way to get the name and version of the current extension.
-// tslint:disable-next-line: no-var-requires
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-var-requires
 const PackageJSON: any = require("../package.json");
 
 // the application insights key (also known as instrumentation key) used for telemetry.

src/platform.ts

@@ -7,7 +7,7 @@ import * as process from "process";
 import { IPowerShellAdditionalExePathSettings } from "./settings";
 
 // This uses require so we can rewire it in unit tests!
-// tslint:disable-next-line:no-var-requires
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-var-requires
 const utils = require("./utils");
 
 const WindowsPowerShell64BitLabel = "Windows PowerShell (x64)";
@@ -298,7 +298,6 @@ export class PowerShellExeFinder {
 
         // We should find only one such application, so return on the first one
         for (const name of await utils.readDirectory(msixAppDir)) {
-            // tslint:disable-next-line:no-bitwise
             if (pwshMsixDirRegex.test(name)) {
                 return new PossiblePowerShellExe(path.join(msixAppDir, name, "pwsh.exe"), pwshMsixName);
             }

src/session.ts

@@ -912,7 +912,7 @@ class SessionMenuItem implements vscode.QuickPickItem {
 
     constructor(
         public readonly label: string,
-        // tslint:disable-next-line:no-empty
+        // eslint-disable-next-line @typescript-eslint/no-empty-function
         public readonly callback: () => void = () => { }) {
     }
 }

src/settings.ts

@@ -265,7 +265,6 @@ export function load(): ISettings {
         notebooks:
             configuration.get<INotebooksSettings>("notebooks", defaultNotebooksSettings),
         startAsLoginShell:
-            // tslint:disable-next-line
             // We follow the same convention as VS Code - https://github.com/microsoft/vscode/blob/ff00badd955d6cfcb8eab5f25f3edc86b762f49f/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts#L105-L107
             //   "Unlike on Linux, ~/.profile is not sourced when logging into a macOS session. This
             //   is the reason terminals on macOS typically run login shells by default which set up

src/utils.ts

@@ -25,7 +25,6 @@ async function checkIfFileOrDirectoryExists(targetPath: string | vscode.Uri, typ
             targetPath instanceof vscode.Uri
                 ? targetPath
                 : vscode.Uri.file(targetPath));
-        // tslint:disable-next-line:no-bitwise
         return (stat.type & type) !== 0;
     } catch {
         // TODO: Maybe throw if it's not a FileNotFound exception.

test/index.ts

@@ -45,7 +45,6 @@ export function run(): Promise<void> {
                     }
                 });
             } catch (err) {
-                // tslint:disable-next-line:no-console
                 console.error(err);
                 e(err);
             }

test/runTests.ts

@@ -28,7 +28,6 @@ async function main() {
             version: "insiders"
         });
     } catch (err) {
-        // tslint:disable-next-line:no-console
         console.error(`Failed to run tests: ${err}`);
         process.exit(1);
     }

test/utils.ts

@@ -8,7 +8,7 @@ import { IPowerShellExtensionClient } from "../src/features/ExternalApi";
 // This lets us test the rest of our path assumptions against the baseline of
 // this test file existing at `<root>/out/test/utils.js`.
 export const rootPath = path.resolve(__dirname, "../../");
-// tslint:disable-next-line: no-var-requires
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-var-requires
 const packageJSON: any = require(path.resolve(rootPath, "package.json"));
 export const extensionId = `${packageJSON.publisher}.${packageJSON.name}`;