Fix bug when uploading release assets

andyleejordan · andyleejordan · commit fb570b5fd99e · 2021-07-15T15:58:35.000-07:00
diff --git a/tools/ReleaseTools.psm1 b/tools/ReleaseTools.psm1
@@ -424,7 +424,10 @@ function New-DraftRelease {
     $Release = New-GitHubRelease @ReleaseParams
     if ($Release) {
         Write-Host "Draft release URL: $($Release.html_url)"
+        # NOTE: We must loop around `New-GitHubReleaseAsset` so we can pipe
+        # `$Release` or it can fail to find the newly created release by its ID
+        # (probably a race condition).
         Write-Host "Uploading assets..."
-        $Assets | New-GitHubReleaseAsset -Release $Release.Id
+        $Assets | ForEach-Object { $Release | New-GitHubReleaseAsset -Path $_ }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,10 @@ function New-DraftRelease {`
`424`	`424`	`$Release = New-GitHubRelease @ReleaseParams`
`425`	`425`	`if ($Release) {`
`426`	`426`	`Write-Host "Draft release URL: $($Release.html_url)"`
	`427`	+ # NOTE: We must loop around `New-GitHubReleaseAsset` so we can pipe
	`428`	+ # `$Release` or it can fail to find the newly created release by its ID
	`429`	`+ # (probably a race condition).`
`427`	`430`	`Write-Host "Uploading assets..."`
`428`		`- $Assets \| New-GitHubReleaseAsset -Release $Release.Id`
	`431`	`+ $Assets \| ForEach-Object { $Release \| New-GitHubReleaseAsset -Path $_ }`
`429`	`432`	`}`
`430`	`433`	`}`