Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field type selector default value causes a bug #264

Open
ukoo-jordan opened this issue Oct 9, 2024 · 2 comments
Open

Field type selector default value causes a bug #264

ukoo-jordan opened this issue Oct 9, 2024 · 2 comments

Comments

@ukoo-jordan
Copy link

ukoo-jordan commented Oct 9, 2024

Hi, I encountered several issues with selector field.

  1. When you put default value for field type selector (i.e : 'default' => 'Choose'), it causes a bug and settings are not visible anymore. (It's written in documentation by the way)
  2. If you remove the default value, it automatically takes the field label instead of a generic or blank default value. (Not a problem if first point is corrected in my opinion)
  3. Then, if you select a category for example, it's impossible to remove it

Thank you!

@PrestaSafe
Copy link
Owner

I see, it could be great to have a 'delete' option or something else.

For the matching, i'll make some test. Do you have an exemple to give me for testing please ?

@ukoo-jordan
Copy link
Author

The example that I personally had was a promotions block which allows you to retrieve native PrestaShop promotions, which I added the possibility through a selector type field to choose a category. This allows me to display promotions for a specific category. The parameters and display are identical, only the query changes.

We could even go further and provide a second selector and highlight the promotions of a brand rather than a category, but for the moment, I have not encountered this double case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants