Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps_facetedsearch - In template creation, filters counter in BO is not correct #37587

Closed
2 tasks done
florine2623 opened this issue Dec 5, 2024 · 3 comments
Closed
2 tasks done
Labels
9.0.x Branch BO Category: Back Office Bug Type: Bug Faceted search Module: ps_facetedsearch Module Module Modules Component: Which BO section is concerned Verified The issue has been reproduced

Comments

@florine2623
Copy link
Contributor

Prerequisites

Describe the bug and add attachments

When I create a new filters template, the total filters counter is not correct.

in my case, I have Total filters: 12, but when I check all of them, I have 13.

Expected behavior

The Total filters: 12 and the actual number of filters should be the same.

Image

Steps to reproduce

  1. Go to BO > Modules > Configure ps_facetedsearch
  2. Click Add new template
  3. In Filters, enable all of them. You will see 13.
  4. But in the Total filters, you will see 12 ❌

PrestaShop version(s) where the bug happened

9.0.0

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

ps_facetedsearch v4.0.0

Your company or customer's name goes here (if applicable).

No response

@florine2623 florine2623 added Bug Type: Bug New New issue not yet processed by QA labels Dec 5, 2024
@paulnoelcholot
Copy link

paulnoelcholot commented Dec 10, 2024

Hello @florine2623,

I reproduce the issue with PrestaShop version 9.0.0, I'll add this to the backlog so it can be fixed.

Please be aware that some issues might take a very long time to be resolved. If this one is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider contacting a professional to help you.

If you fix the issue on your end, please contribute it back to the project. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

Image

@paulnoelcholot paulnoelcholot added BO Category: Back Office Modules Component: Which BO section is concerned Faceted search Module: ps_facetedsearch Ready Status: Issue is ready to be worked on Verified The issue has been reproduced Module Module 9.0.x Branch and removed New New issue not yet processed by QA labels Dec 10, 2024
@Codencode
Copy link
Contributor

The problem is that the fixed filters are 7 and not 6:

  1. Sub-categories filter
  2. Product stock filter
  3. Product extras filter
  4. Product condition filter
  5. Product brand filter
  6. Product weight filter (slider)
  7. Product price filter (slider)

The problem lies here:
https://github.com/Codencode/ps_facetedsearch/blob/edb3292ebb699e1067845a50c5a554a28ca3c523/ps_facetedsearch.php#L869-L880

Now I'll create a PR.

@Codencode
Copy link
Contributor

@Hlavtox Hlavtox closed this as completed Dec 19, 2024
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0.x Branch BO Category: Back Office Bug Type: Bug Faceted search Module: ps_facetedsearch Module Module Modules Component: Which BO section is concerned Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

4 participants