Skip to content

Commit a07c658

Browse files
authored
Merge pull request #234 from Progi1984/boProductsCreateTabDetailsPage
Migrate `@pages/BO/catalog/products/add/detailsTab` from Core
2 parents b0e5303 + 1488415 commit a07c658

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/interfaces/BO/catalog/products/create/tabDetails.ts

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import type FakerProduct from '@data/faker/product';
66
import type {ProductFeatures} from '@data/types/product';
77

88
export interface BOProductsCreateTabDetailsPageInterface extends BOBasePagePageInterface {
9+
readonly featureCustomValueNotDefaultLanguageMessage: string;
10+
911
addNewCustomizations(page: Page, productData: FakerProduct): Promise<void>;
1012
addNewFile(page: Page, productData: FakerProduct): Promise<void>;
1113
clickOnManageAllFiles(page: Page): Promise<Page>;

src/versions/develop/pages/BO/catalog/products/create/tabDetails.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import BOBasePage from '@pages/BO/BOBasePage';
2-
import createProductPage from '@pages/BO/catalog/products/create';
2+
import boProductsCreatePage from '@pages/BO/catalog/products/create';
33

44
// Import data
55
import type FakerProduct from '@data/faker/product';
@@ -176,6 +176,7 @@ class DetailsTab extends BOBasePage implements BOProductsCreateTabDetailsPageInt
176176
async setProductDetails(page: Page, productData: FakerProduct): Promise<void> {
177177
await this.waitForSelectorAndClick(page, this.detailsTabLink);
178178
await this.setValue(page, this.productReferenceInput, productData.reference);
179+
await this.setCondition(page, productData);
179180
}
180181

181182
/**
@@ -225,7 +226,7 @@ class DetailsTab extends BOBasePage implements BOProductsCreateTabDetailsPageInt
225226
* @returns {Promise<string>}
226227
*/
227228
async getErrorMessageInReferencesForm(page: Page, inputNumber: number): Promise<string> {
228-
await createProductPage.clickOnSaveProductButton(page);
229+
await boProductsCreatePage.clickOnSaveProductButton(page);
229230

230231
return this.getTextContent(page, this.referenceFormErrorMessage(inputNumber));
231232
}
@@ -361,7 +362,9 @@ class DetailsTab extends BOBasePage implements BOProductsCreateTabDetailsPageInt
361362
*/
362363
async setCondition(page: Page, productData: FakerProduct): Promise<void> {
363364
await this.setChecked(page, this.displayCondition(productData.displayCondition ? 1 : 0));
364-
await this.selectByVisibleText(page, this.productConditionSelect, productData.condition);
365+
if (productData.displayCondition === true) {
366+
await this.selectByVisibleText(page, this.productConditionSelect, productData.condition);
367+
}
365368
}
366369

367370
/**

0 commit comments

Comments
 (0)