fix: prevent preview from being disabled when printer selected (#405)

* fix: prevent preview settings from being disabled when printer is selected
* refactor: remove triple call to set combobox value

---------

Signed-off-by: Pavel Polyakov <[email protected]>

Author: Jeredian

MachineConfig.py

@@ -274,7 +274,7 @@ def supportScreenshot(self):
         global_container_stack = Application.getInstance().getGlobalContainerStack()
         if global_container_stack:
             meta_data = global_container_stack.getMetaData()
-            if Constants.SIMAGE in meta_data or Constants.GIMAGE in meta_data:
+            if Constants.SCREENSHOT_INDEX in meta_data or Constants.SIMAGE in meta_data or Constants.GIMAGE in meta_data:
                 return True
         return False
 

qml/MachineConfig.qml

@@ -21,12 +21,6 @@ Cura.MachineAction {
 
     property var printerSupportScreenshots: manager.supportScreenshot()
     property var printerScreenshotSizesList: manager.getScreenshotOptions()
-    property var printerScreenshotIndex: {
-        var sIndex = manager.getScreenshotIndex()
-
-        screenshotComboBox.currentIndex = sIndex
-        return sIndex
-    }
 
     function connectPrinter() {
         if(base.selectedPrinter) {
@@ -334,11 +328,10 @@ Cura.MachineAction {
                                     manager.setSimage("")
                                     manager.setGimage("")
                                     manager.setScreenshotIndex("")
-                                    screenshotComboBox.currentIndex = 0
                                 }
                                 simageTextInput.text = manager.getSimage()
                                 gimageTextInput.text = manager.getGimage()
-                                screenshotComboBox.currentIndex = printerScreenshotIndex
+                                screenshotComboBox.currentIndex = manager.getScreenshotIndex()
                             }
 
                             enabled: mksSupport.checked