Skip to content

Commit 99a2ae4

Browse files
committed
Fix install script to work behind proxy
1 parent 6f60ac7 commit 99a2ae4

File tree

3 files changed

+17
-21
lines changed

3 files changed

+17
-21
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "native-image-diff",
3-
"version": "0.0.1",
3+
"version": "0.0.2",
44
"description": "A simple library for comparing two images using a native C++ binding.",
55
"main": "dist/index.js",
66
"author": "Frederick Gnodtke",
@@ -21,12 +21,12 @@
2121
"url": "https://github.com/Prior99/native-image-diff"
2222
},
2323
"files": [
24+
"index.d.ts",
2425
"./dist",
2526
"./docs",
2627
"./images",
2728
"./scripts",
2829
"./src",
29-
"./index.d.ts",
3030
"./LICENSE",
3131
"./README.md"
3232
],
@@ -75,6 +75,6 @@
7575
"typescript": "^2.6.1"
7676
},
7777
"dependencies": {
78-
"node-fetch": "^2.1.2"
78+
"request": "^2.85.0"
7979
}
8080
}

scripts/install.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const path = require("path");
22
const fs = require("fs");
3-
const fetch = require("node-fetch");
3+
const request = require("request");
44
const fileName = require("./file-name");
55

66
if (fs.existsSync(fileName.qualifiedName)) { return; }
@@ -11,21 +11,21 @@ const pkg = require(path.resolve(__dirname, "..", "package.json"));
1111
const packageVersion = pkg.version;
1212
const url = `https://github.com/Prior99/native-image-diff/releases/download/${packageVersion}/${fileName.baseName}`;
1313

14-
fetch(url)
15-
.then(response => {
16-
if (response.ok) {
17-
return response.buffer();
14+
request.get(url)
15+
.on("error", err => { throw err; })
16+
.on("response", response => {
17+
if (response.statusCode >= 200 && response.statusCode < 300) {
18+
response.pipe(destination);
19+
destination.on("finish", () => {
20+
console.info("Successfully downloaded binaries for native-image-diff.");
21+
});
22+
return;
1823
}
19-
if (response.status === 404) {
24+
if (response.statusCode === 404) {
2025
throw new Error(`No supported native-image-diff ${packageVersion} build found for node ${process.version} on ${process.platform} (${process.arch}).`);
2126
} else {
2227
throw new Error(`Error downloading binaries for native-image-diff ${packageVersion}. Received status code ${response.statusCode}`);
2328
}
24-
})
25-
.catch(err => {
26-
throw new Error(err);
27-
})
28-
.then(buffer => {
29-
fs.writeFileSync(fileName.qualifiedName, buffer);
30-
console.info("Successfully downloaded binaries for native-image-diff.");
31-
})
29+
destination.close();
30+
fs.unlink(fileName.qualifiedName);
31+
});

yarn.lock

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2190,10 +2190,6 @@ natural-compare@^1.4.0:
21902190
version "1.4.0"
21912191
resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7"
21922192

2193-
node-fetch@^2.1.2:
2194-
version "2.1.2"
2195-
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.1.2.tgz#ab884e8e7e57e38a944753cec706f788d1768bb5"
2196-
21972193
node-gyp@^3.6.2:
21982194
version "3.6.2"
21992195
resolved "https://registry.yarnpkg.com/node-gyp/-/node-gyp-3.6.2.tgz#9bfbe54562286284838e750eac05295853fa1c60"

0 commit comments

Comments
 (0)